[
https://issues.apache.org/jira/browse/HIVE-21195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757830#comment-16757830
]
Hive QA commented on HIVE-21195:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12957175/HIVE-21195.1.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/15872/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15872/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15872/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2019-02-01 00:34:31.938
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-15872/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2019-02-01 00:34:31.941
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at f2e10f2 HIVE-21029: External table replication for existing
deployments running incremental replication (Sankar Hariappan, reviewed by
Mahesh Kumar Behera)
+ git clean -f -d
Removing standalone-metastore/metastore-server/src/gen/
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at f2e10f2 HIVE-21029: External table replication for existing
deployments running incremental replication (Sankar Hariappan, reviewed by
Mahesh Kumar Behera)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2019-02-01 00:34:33.077
+ rm -rf ../yetus_PreCommit-HIVE-Build-15872
+ mkdir ../yetus_PreCommit-HIVE-Build-15872
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-15872
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-15872/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
error: a/ql/src/java/org/apache/hadoop/hive/ql/lib/DefaultGraphWalker.java:
does not exist in index
Going to apply patch with: git apply -p1
+ [[ maven == \m\a\v\e\n ]]
+ rm -rf /data/hiveptest/working/maven/org/apache/hive
+ mvn -B clean install -DskipTests -T 4 -q
-Dmaven.repo.local=/data/hiveptest/working/maven
protoc-jar: executing: [/tmp/protoc5402898439180160781.exe, --version]
libprotoc 2.5.0
protoc-jar: executing: [/tmp/protoc5402898439180160781.exe,
-I/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore,
--java_out=/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/target/generated-sources,
/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore/metastore.proto]
ANTLR Parser Generator Version 3.5.2
protoc-jar: executing: [/tmp/protoc54735899005268837.exe, --version]
libprotoc 2.5.0
ANTLR Parser Generator Version 3.5.2
Output file
/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-server/target/generated-sources/org/apache/hadoop/hive/metastore/parser/FilterParser.java
does not exist: must build
/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/Filter.g
org/apache/hadoop/hive/metastore/parser/Filter.g
log4j:WARN No appenders could be found for logger (DataNucleus.Persistence).
log4j:WARN Please initialize the log4j system properly.
DataNucleus Enhancer (version 4.1.17) for API "JDO"
DataNucleus Enhancer completed with success for 41 classes.
ANTLR Parser Generator Version 3.5.2
Output file
/data/hiveptest/working/apache-github-source-source/ql/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HiveLexer.java
does not exist: must build
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g
org/apache/hadoop/hive/ql/parse/HiveLexer.g
Output file
/data/hiveptest/working/apache-github-source-source/ql/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HiveParser.java
does not exist: must build
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
org/apache/hadoop/hive/ql/parse/HiveParser.g
warning(200): org/apache/hadoop/hive/ql/parse/HiveParser.g:808:14:
Decision can match input such as "KW_EXTENDED" using multiple alternatives: 1, 2
As a result, alternative(s) 2 were disabled for that input
warning(200): org/apache/hadoop/hive/ql/parse/HiveParser.g:2439:5:
Decision can match input such as "KW_CHECK KW_DATETIME" using multiple
alternatives: 1, 2
As a result, alternative(s) 2 were disabled for that input
warning(200): org/apache/hadoop/hive/ql/parse/HiveParser.g:2439:5:
Decision can match input such as "KW_CHECK KW_DATE {LPAREN, StringLiteral}"
using multiple alternatives: 1, 2
As a result, alternative(s) 2 were disabled for that input
warning(200): org/apache/hadoop/hive/ql/parse/HiveParser.g:2439:5:
Decision can match input such as "KW_CHECK KW_UNIONTYPE LESSTHAN" using
multiple alternatives: 1, 2
As a result, alternative(s) 2 were disabled for that input
warning(200): org/apache/hadoop/hive/ql/parse/HiveParser.g:2439:5:
Decision can match input such as "KW_CHECK {KW_EXISTS, KW_TINYINT}" using
multiple alternatives: 1, 2
As a result, alternative(s) 2 were disabled for that input
warning(200): org/apache/hadoop/hive/ql/parse/HiveParser.g:2439:5:
Decision can match input such as "KW_CHECK KW_STRUCT LESSTHAN" using multiple
alternatives: 1, 2
As a result, alternative(s) 2 were disabled for that input
warning(200): IdentifiersParser.g:424:5:
Decision can match input such as "KW_UNKNOWN" using multiple alternatives: 1, 10
As a result, alternative(s) 10 were disabled for that input
Output file
/data/hiveptest/working/apache-github-source-source/ql/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HintParser.java
does not exist: must build
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/parse/HintParser.g
org/apache/hadoop/hive/ql/parse/HintParser.g
Generating vector expression code
Generating vector expression test code
Processing annotations
Annotations processed
Processing annotations
No elements to process
[ERROR] COMPILATION ERROR :
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkWorkWalker.java:[70,30]
incompatible types: boolean cannot be converted to
org.apache.hadoop.hive.ql.lib.Node
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagate.java:[155,15]
no suitable method found for add(int,org.apache.hadoop.hive.ql.lib.Node)
method java.util.Collection.add(org.apache.hadoop.hive.ql.lib.Node) is not
applicable
(actual and formal argument lists differ in length)
method java.util.Queue.add(org.apache.hadoop.hive.ql.lib.Node) is not
applicable
(actual and formal argument lists differ in length)
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagate.java:[156,15]
method addAll in interface java.util.Collection<E> cannot be applied to given
types;
required: java.util.Collection<? extends org.apache.hadoop.hive.ql.lib.Node>
found: int,java.util.List<org.apache.hadoop.hive.ql.lib.Node>
reason: actual and formal argument lists differ in length
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/lib/ForwardWalker.java:[55,11]
method addAll in interface java.util.Collection<E> cannot be applied to given
types;
required: java.util.Collection<? extends org.apache.hadoop.hive.ql.lib.Node>
found: int,java.util.List<org.apache.hadoop.hive.ql.exec.Operator<? extends
org.apache.hadoop.hive.ql.plan.OperatorDesc>>
reason: actual and formal argument lists differ in length
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/lib/ForwardWalker.java:[80,11]
no suitable method found for add(int,org.apache.hadoop.hive.ql.lib.Node)
method java.util.Collection.add(org.apache.hadoop.hive.ql.lib.Node) is not
applicable
(actual and formal argument lists differ in length)
method java.util.Queue.add(org.apache.hadoop.hive.ql.lib.Node) is not
applicable
(actual and formal argument lists differ in length)
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/lib/LevelOrderWalker.java:[99,17]
cannot find symbol
symbol: method get(int)
location: variable toWalk of type
java.util.Queue<org.apache.hadoop.hive.ql.lib.Node>
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/lib/LevelOrderWalker.java:[100,32]
cannot find symbol
symbol: method get(int)
location: variable toWalk of type
java.util.Queue<org.apache.hadoop.hive.ql.lib.Node>
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezWorkWalker.java:[70,30]
incompatible types: boolean cannot be converted to
org.apache.hadoop.hive.ql.lib.Node
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPruner.java:[183,13]
method addAll in interface java.util.Collection<E> cannot be applied to given
types;
required: java.util.Collection<? extends org.apache.hadoop.hive.ql.lib.Node>
found: int,java.util.List<capture#1 of ? extends
org.apache.hadoop.hive.ql.lib.Node>
reason: actual and formal argument lists differ in length
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile (default-compile)
on project hive-exec: Compilation failure: Compilation failure:
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkWorkWalker.java:[70,30]
incompatible types: boolean cannot be converted to
org.apache.hadoop.hive.ql.lib.Node
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagate.java:[155,15]
no suitable method found for add(int,org.apache.hadoop.hive.ql.lib.Node)
[ERROR] method java.util.Collection.add(org.apache.hadoop.hive.ql.lib.Node) is
not applicable
[ERROR] (actual and formal argument lists differ in length)
[ERROR] method java.util.Queue.add(org.apache.hadoop.hive.ql.lib.Node) is not
applicable
[ERROR] (actual and formal argument lists differ in length)
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagate.java:[156,15]
method addAll in interface java.util.Collection<E> cannot be applied to given
types;
[ERROR] required: java.util.Collection<? extends
org.apache.hadoop.hive.ql.lib.Node>
[ERROR] found: int,java.util.List<org.apache.hadoop.hive.ql.lib.Node>
[ERROR] reason: actual and formal argument lists differ in length
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/lib/ForwardWalker.java:[55,11]
method addAll in interface java.util.Collection<E> cannot be applied to given
types;
[ERROR] required: java.util.Collection<? extends
org.apache.hadoop.hive.ql.lib.Node>
[ERROR] found: int,java.util.List<org.apache.hadoop.hive.ql.exec.Operator<?
extends org.apache.hadoop.hive.ql.plan.OperatorDesc>>
[ERROR] reason: actual and formal argument lists differ in length
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/lib/ForwardWalker.java:[80,11]
no suitable method found for add(int,org.apache.hadoop.hive.ql.lib.Node)
[ERROR] method java.util.Collection.add(org.apache.hadoop.hive.ql.lib.Node) is
not applicable
[ERROR] (actual and formal argument lists differ in length)
[ERROR] method java.util.Queue.add(org.apache.hadoop.hive.ql.lib.Node) is not
applicable
[ERROR] (actual and formal argument lists differ in length)
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/lib/LevelOrderWalker.java:[99,17]
cannot find symbol
[ERROR] symbol: method get(int)
[ERROR] location: variable toWalk of type
java.util.Queue<org.apache.hadoop.hive.ql.lib.Node>
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/lib/LevelOrderWalker.java:[100,32]
cannot find symbol
[ERROR] symbol: method get(int)
[ERROR] location: variable toWalk of type
java.util.Queue<org.apache.hadoop.hive.ql.lib.Node>
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezWorkWalker.java:[70,30]
incompatible types: boolean cannot be converted to
org.apache.hadoop.hive.ql.lib.Node
[ERROR]
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPruner.java:[183,13]
method addAll in interface java.util.Collection<E> cannot be applied to given
types;
[ERROR] required: java.util.Collection<? extends
org.apache.hadoop.hive.ql.lib.Node>
[ERROR] found: int,java.util.List<capture#1 of ? extends
org.apache.hadoop.hive.ql.lib.Node>
[ERROR] reason: actual and formal argument lists differ in length
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :hive-exec
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-15872
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12957175 - PreCommit-HIVE-Build
> Review of DefaultGraphWalker Class
> ----------------------------------
>
> Key: HIVE-21195
> URL: https://issues.apache.org/jira/browse/HIVE-21195
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 4.0.0, 3.2.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Attachments: HIVE-21195.1.patch
>
>
> {code:java}
> protected final List<Node> toWalk = new ArrayList<Node>();
> ...
> while (toWalk.size() > 0) {
> Node nd = toWalk.remove(0);
> {code}
> Every time this loop runs, the first item of a list is removed. For an
> {{ArrayList}}, this means that every time the first item is removed, all of
> the remaining items in the list are copied down one position so that the
> first item is always at array index 0. This is expensive in a tight loop.
> Use a {{Queue}} implementation that does not have this behavior.
> {{ArrayDeque}}
> {quote}
> This class is likely to be faster than Stack when used as a stack, and faster
> than LinkedList when used as a queue.
> {quote}
> https://docs.oracle.com/javase/7/docs/api/java/util/ArrayDeque.html
> Add a little bit extra cleanup since it's being looked at.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
