[
https://issues.apache.org/jira/browse/HIVE-21252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16766565#comment-16766565
]
Hive QA commented on HIVE-21252:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12958443/HIVE-21252.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 15786 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/16040/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16040/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16040/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12958443 - PreCommit-HIVE-Build
> LazyTimestamp - Use String Equals
> ---------------------------------
>
> Key: HIVE-21252
> URL: https://issues.apache.org/jira/browse/HIVE-21252
> Project: Hive
> Issue Type: Improvement
> Components: Serializers/Deserializers
> Affects Versions: 4.0.0, 3.2.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Attachments: HIVE-21252.1.patch
>
>
> {code:java|title=LazyTimestamp.java}
> if (s.compareTo("NULL") == 0) {
> isNull = true;
> logExceptionMessage(bytes, start, length, "TIMESTAMP");
> }
> {code}
> compareTo generates a number to represent the differences between the two
> Strings. It's faster to simply call "equals" which will simply compare the
> two String directly and return a boolean.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
