[ https://issues.apache.org/jira/browse/HIVE-21303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777103#comment-16777103 ]
Hive QA commented on HIVE-21303: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12960038/HIVE-21303.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 24 failed/errored test(s), 15811 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby_bigdata] (batchId=127) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[input14] (batchId=147) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[input17] (batchId=128) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[input18] (batchId=119) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[insert_into1] (batchId=121) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[insert_into2] (batchId=152) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[insert_into3] (batchId=123) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[mapreduce1] (batchId=142) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[mapreduce2] (batchId=122) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_transform] (batchId=146) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[rcfile_bigdata] (batchId=121) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[script_env_var1] (batchId=113) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[script_env_var2] (batchId=138) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[script_pipe] (batchId=145) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[scriptfile1] (batchId=149) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[transform1] (batchId=128) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[transform2] (batchId=129) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[transform_ppr1] (batchId=117) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[transform_ppr2] (batchId=131) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[union23] (batchId=112) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[union_script] (batchId=142) org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver.testCliDriver[spark_job_max_tasks] (batchId=277) org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver.testCliDriver[spark_stage_max_tasks] (batchId=277) org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver.testCliDriver[spark_task_failure] (batchId=277) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16236/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16236/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16236/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 24 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12960038 - PreCommit-HIVE-Build > Update TextRecordReader > ----------------------- > > Key: HIVE-21303 > URL: https://issues.apache.org/jira/browse/HIVE-21303 > Project: Hive > Issue Type: Improvement > Components: Query Processor > Affects Versions: 4.0.0, 3.2.0 > Reporter: BELUGA BEHR > Assignee: BELUGA BEHR > Priority: Major > Attachments: HIVE-21303.1.patch, HIVE-21303.2.patch > > > Remove use of Deprecated > {{org.apache.hadoop.mapred.LineRecordReader.LineReader}} > For every call to {{next}}, the code dives into the configuration map to see > if this feature is enabled. Just look it up once and cache the value. > {code:java} > public int next(Writable row) throws IOException { > ... > if (HiveConf.getBoolVar(conf, HiveConf.ConfVars.HIVESCRIPTESCAPE)) { > return HiveUtils.unescapeText((Text) row); > } > return bytesConsumed; > } > {code} > Other clean up. -- This message was sent by Atlassian JIRA (v7.6.3#76005)