[ https://issues.apache.org/jira/browse/HIVE-21197?focusedWorklogId=204097&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-204097 ]
ASF GitHub Bot logged work on HIVE-21197: ----------------------------------------- Author: ASF GitHub Bot Created on: 26/Feb/19 05:40 Start Date: 26/Feb/19 05:40 Worklog Time Spent: 10m Work Description: sankarh commented on pull request #541: HIVE-21197 : Hive Replication can add duplicate data during migration to a target with hive.strict.managed.tables enabled URL: https://github.com/apache/hive/pull/541#discussion_r260131896 ########## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java ########## @@ -5216,7 +5216,8 @@ private int updateFirstIncPendingFlag(Hive hive, ReplSetFirstIncLoadFlagDesc des for (String tableName : Utils.matchesTbl(hive, dbNameOrPattern, tableNameOrPattern)) { org.apache.hadoop.hive.metastore.api.Table tbl = hive.getMSC().getTable(dbNameOrPattern, tableName); parameters = tbl.getParameters(); - if (ReplUtils.isFirstIncPending(parameters)) { + String incPendPara = parameters != null ? parameters.get(ReplUtils.REPL_FIRST_INC_PENDING_FLAG) : null; + if (incPendPara != null && (!flag.equalsIgnoreCase(incPendPara))) { Review comment: If incPendPara = null also need to set the flag. Now it will skip. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 204097) Time Spent: 21h 50m (was: 21h 40m) > Hive replication can add duplicate data during migration to a target with > hive.strict.managed.tables enabled > ------------------------------------------------------------------------------------------------------------ > > Key: HIVE-21197 > URL: https://issues.apache.org/jira/browse/HIVE-21197 > Project: Hive > Issue Type: Task > Components: repl > Reporter: mahesh kumar behera > Assignee: mahesh kumar behera > Priority: Major > Labels: pull-request-available > Attachments: HIVE-21197.01.patch, HIVE-21197.02.patch, > HIVE-21197.03.patch, HIVE-21197.04.patch > > Time Spent: 21h 50m > Remaining Estimate: 0h > > During bootstrap phase it may happen that the files copied to target are > created by events which are not part of the bootstrap. This is because of the > fact that, bootstrap first gets the last event id and then the file list. > During this period if some event are added, then bootstrap will include files > created by these events also.The same files will be copied again during the > first incremental replication just after the bootstrap. In normal scenario, > the duplicate copy does not cause any issue as hive allows the use of target > database only after the first incremental. But in case of migration, the file > at source and target are copied to different location (based on the write id > at target) and thus this may lead to duplicate data at target. This can be > avoided by having at check at load time for duplicate file. This check can be > done only for the first incremental and the search can be done in the > bootstrap directory (with write id 1). if the file is already present then > just ignore the copy. -- This message was sent by Atlassian JIRA (v7.6.3#76005)