[
https://issues.apache.org/jira/browse/HIVE-21198?focusedWorklogId=204220&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-204220
]
ASF GitHub Bot logged work on HIVE-21198:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Feb/19 12:11
Start Date: 26/Feb/19 12:11
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on pull request #550: HIVE-21198
Introduce a database object reference class
URL: https://github.com/apache/hive/pull/550#discussion_r260253361
##########
File path:
hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
##########
@@ -348,8 +348,8 @@ protected void
authorizeDDLWork(HiveSemanticAnalyzerHookContext cntxt, Hive hive
AlterTableDesc alterTable = work.getAlterTblDesc();
if (alterTable != null) {
- Table table = hive.getTable(SessionState.get().getCurrentDatabase(),
- Utilities.getDbTableName(alterTable.getOldName())[1], false);
+ final String tableName =
Utilities.getTableName(alterTable.getOldName()).getTable();
Review comment:
I guess we can't add `of` methods to `TableName`; but I feel like putting
this into "Utilities" is kinda unfortunate.
How about: `HiveTableName.of(...)`
If you need any utilities you can probably make HiveTableName extend
TableName - not sure if that will be needed or not
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 204220)
Time Spent: 50m (was: 40m)
> Introduce a database object reference class
> -------------------------------------------
>
> Key: HIVE-21198
> URL: https://issues.apache.org/jira/browse/HIVE-21198
> Project: Hive
> Issue Type: Improvement
> Reporter: Zoltan Haindrich
> Assignee: David Lavati
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21198.1.patch, HIVE-21198.2.patch,
> HIVE-21198.3.patch, HIVE-21198.4.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> There are many places in which "{databasename}.{tablename}" is passed as a
> single string; there are some places where the they travel as 2 separate
> arguments.
> Idea would be to introduce a simple immutable class with 2 fields ; and pass
> these informations together. Making this better is required if we would be
> wanting to enable dot in tablenames
> HIVE-16907, HIVE-21151
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
