[
https://issues.apache.org/jira/browse/HIVE-21339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16780230#comment-16780230
]
Gopal V commented on HIVE-21339:
--------------------------------
LGTM - +1
> LLAP: Cache hit also initializes an FS object
> ----------------------------------------------
>
> Key: HIVE-21339
> URL: https://issues.apache.org/jira/browse/HIVE-21339
> Project: Hive
> Issue Type: Bug
> Components: llap
> Affects Versions: 4.0.0
> Reporter: Gopal V
> Assignee: Prasanth Jayachandran
> Priority: Major
> Attachments: HIVE-21339.1.patch, HIVE-21339.2.patch,
> llap-cache-fs-get.png, llap-query7-cached.svg
>
>
> https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java#L214
> {code}
> // 1. Get file metadata from cache, or create the reader and read it.
> // Don't cache the filesystem object for now; Tez closes it and FS cache
> will fix all that
> fs = split.getPath().getFileSystem(jobConf);
> fileKey = determineFileId(fs, split,
> HiveConf.getBoolVar(daemonConf,
> ConfVars.LLAP_CACHE_ALLOW_SYNTHETIC_FILEID),
> HiveConf.getBoolVar(daemonConf,
> ConfVars.LLAP_CACHE_DEFAULT_FS_FILE_ID),
> !HiveConf.getBoolVar(daemonConf, ConfVars.LLAP_IO_USE_FILEID_PATH)
> );
> {code}
> !llap-cache-fs-get.png!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
