[
https://issues.apache.org/jira/browse/HIVE-20057?focusedWorklogId=205788&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-205788
]
ASF GitHub Bot logged work on HIVE-20057:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Feb/19 13:31
Start Date: 28/Feb/19 13:31
Worklog Time Spent: 10m
Work Description: sankarh commented on pull request #388: HIVE-20057: Fix
Hive table conversion DESCRIBE table bug
URL: https://github.com/apache/hive/pull/388#discussion_r261195039
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -1802,12 +1802,12 @@ private MTable convertToMTable(Table tbl) throws
InvalidObjectException,
// accordingly
String tableType = tbl.getTableType();
boolean isExternal =
Boolean.parseBoolean(tbl.getParameters().get("EXTERNAL"));
- if (TableType.MANAGED_TABLE.toString().equals(tableType)) {
+ if (TableType.MANAGED_TABLE.toString().equalsIgnoreCase(tableType)) {
Review comment:
I think, this issue doesn't exist in master code.
We use Boolean.parseBoolean to read the "EXTERNAL" property which ignores
case. Also, the fix in the patch is to use equalsIgnoreCase when compare the
TableType and not "EXTERNAL" property which is irrelevant.
If I misunderstood your scenario, please let me know.
Also, it would be better to add a unit test to reproduce this bug in master
code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 205788)
Time Spent: 1h (was: 50m)
> For ALTER TABLE t SET TBLPROPERTIES ('EXTERNAL'='TRUE'); `TBL_TYPE` attribute
> change not reflecting for non-CAPS
> ----------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-20057
> URL: https://issues.apache.org/jira/browse/HIVE-20057
> Project: Hive
> Issue Type: Bug
> Components: Standalone Metastore
> Affects Versions: All Versions
> Reporter: Anirudh
> Assignee: Anirudh
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.1.0
>
> Attachments: hive20057.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Hive EXTERNAL table shown as MANAGED after conversion using
> {code} ALTER TABLE t SET TBLPROPERTIES ('EXTERNAL'='True')
> {code}
>
> The DESCRIBE FORMATTED shows:
> {code}
> Table Type: MANAGED_TABLE
> Table Parameters:
> EXTERNAL True
> {code}
>
> This is actually a External table but is shown wrongly, as 'True' was used in
> place of 'TRUE' in the ALTER statement.
> Issue explained here:
> [StakOverflow - Hive Table is MANAGED or
> EXTERNAL|https://stackoverflow.com/questions/51103317/hive-table-is-managed-or-external/51142873#51142873]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
