[ 
https://issues.apache.org/jira/browse/HIVE-20057?focusedWorklogId=214279&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214279
 ]

ASF GitHub Bot logged work on HIVE-20057:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Mar/19 20:20
            Start Date: 16/Mar/19 20:20
    Worklog Time Spent: 10m 
      Work Description: animenon commented on pull request #388: HIVE-20057: 
Fix Hive table conversion DESCRIBE table bug
URL: https://github.com/apache/hive/pull/388#discussion_r266213837
 
 

 ##########
 File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
 ##########
 @@ -1802,12 +1802,12 @@ private MTable convertToMTable(Table tbl) throws 
InvalidObjectException,
     // accordingly
     String tableType = tbl.getTableType();
     boolean isExternal = 
Boolean.parseBoolean(tbl.getParameters().get("EXTERNAL"));
-    if (TableType.MANAGED_TABLE.toString().equals(tableType)) {
+    if (TableType.MANAGED_TABLE.toString().equalsIgnoreCase(tableType)) {
 
 Review comment:
   @sankarh - For the newer version, HIVE-16324 seems to fix it, the version of 
hive I am using still has this issue, will check my hive version update in 
appropriate branch. 
   Thanks for checking on this.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 214279)
    Time Spent: 3.5h  (was: 3h 20m)

> For ALTER TABLE t SET TBLPROPERTIES ('EXTERNAL'='TRUE'); `TBL_TYPE` attribute 
> change not reflecting for non-CAPS
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-20057
>                 URL: https://issues.apache.org/jira/browse/HIVE-20057
>             Project: Hive
>          Issue Type: Bug
>          Components: Standalone Metastore
>    Affects Versions: All Versions
>            Reporter: Anirudh
>            Assignee: Anirudh
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 3.1.0
>
>         Attachments: hive20057.patch
>
>          Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Hive EXTERNAL table shown as MANAGED after conversion using 
> {code} ALTER TABLE t SET TBLPROPERTIES ('EXTERNAL'='True')
> {code}
>  
> The DESCRIBE FORMATTED shows:
> {code}
> Table Type:            MANAGED_TABLE
> Table Parameters:
>                                EXTERNAL           True
> {code}
>  
> This is actually a External table but is shown wrongly, as 'True' was used in 
> place of 'TRUE' in the ALTER statement.
> Issue explained here: 
> [StakOverflow - Hive Table is MANAGED or 
> EXTERNAL|https://stackoverflow.com/questions/51103317/hive-table-is-managed-or-external/51142873#51142873]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to