[ https://issues.apache.org/jira/browse/HIVE-21471?focusedWorklogId=217327&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-217327 ]
ASF GitHub Bot logged work on HIVE-21471: ----------------------------------------- Author: ASF GitHub Bot Created on: 22/Mar/19 16:37 Start Date: 22/Mar/19 16:37 Worklog Time Spent: 10m Work Description: maheshk114 commented on pull request #578: HIVE-21471: Replicating conversion of managed to external table leaks HDFS files at target. URL: https://github.com/apache/hive/pull/578#discussion_r268130334 ########## File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/common/ReplConst.java ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hive.common; + +/** + * A class that defines the constant strings used by the replication implementation. + */ + +public class ReplConst { Review comment: instead of replConst ..some thing more generic like repl common or util should be used ..so that it can be used for other purpose also ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 217327) Time Spent: 1.5h (was: 1h 20m) > Replicating conversion of managed to external table leaks HDFS files at > target. > ------------------------------------------------------------------------------- > > Key: HIVE-21471 > URL: https://issues.apache.org/jira/browse/HIVE-21471 > Project: Hive > Issue Type: Bug > Components: repl > Affects Versions: 4.0.0 > Reporter: Sankar Hariappan > Assignee: Sankar Hariappan > Priority: Major > Labels: DR, pull-request-available, replication > Attachments: HIVE-21471.01.patch, HIVE-21471.02.patch > > Time Spent: 1.5h > Remaining Estimate: 0h > > While replicating the ALTER event to convert managed table to external table, > the data location for the table is changed under input base directory for > external tables replication. But, the old location remains there and would be > leaked for ever. > ALTER TABLE T1 SET TBLPROPERTIES('EXTERNAL'='true'); -- This message was sent by Atlassian JIRA (v7.6.3#76005)