[ 
https://issues.apache.org/jira/browse/HIVE-21516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803377#comment-16803377
 ] 

Miklos Gergely commented on HIVE-21516:
---------------------------------------

[~kgyrtkirk]
 * rm -rf is used on a directoty
 * can't go to the root, as the script may be invoked both from qtest-spark or 
from hive-unit, and it should work in both cases, this is why relative paths 
must be used

> Fix spark downloading for q tests
> ---------------------------------
>
>                 Key: HIVE-21516
>                 URL: https://issues.apache.org/jira/browse/HIVE-21516
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>    Affects Versions: 3.1.1
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>             Fix For: 4.0.0
>
>         Attachments: HIVE-21516.01.patch, HIVE-21516.02.patch, 
> HIVE-21516.03.patch, HIVE-21516.04.patch
>
>
> Currently itests/pom.xml declares a command to generated the download script 
> for spark, thus it is re-generated every time any maven command is executed 
> for any sub project of itests. AS a side effect it is leaving download.sh 
> files everywhere. The download.sh file is almost totally static, no need to 
> recreate it every time, just requires $spark.version as a parameter.
> Also it is only working properly under linux, as it relies on the md5sum 
> program which is not present in OS X. This means that if the spark tarball is 
> partially downloaded on OS X, then it would never be re-downloaded. This 
> should be fixed by making it work as well using md5 on OS X.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to