[ https://issues.apache.org/jira/browse/HIVE-21537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804775#comment-16804775 ]
Hive QA commented on HIVE-21537: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 38s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 19s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 44s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 33s{color} | {color:blue} ql in master has 2256 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 8s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 18s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 44s{color} | {color:red} ql: The patch generated 3 new + 7 unchanged - 1 fixed = 10 total (was 8) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m 52s{color} | {color:red} ql generated 3 new + 2254 unchanged - 2 fixed = 2257 total (was 2256) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 6s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 27m 52s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:ql | | | Dead store to parentQueryFields in org.apache.hadoop.hive.ql.optimizer.calcite.rules.HiveSubQueryRemoveRule.apply(RelMetadataQuery, RexSubQuery, Set, RelOptUtil$Logic, HiveSubQRemoveRelBuilder, int, int, boolean, boolean) At HiveSubQueryRemoveRule.java:org.apache.hadoop.hive.ql.optimizer.calcite.rules.HiveSubQueryRemoveRule.apply(RelMetadataQuery, RexSubQuery, Set, RelOptUtil$Logic, HiveSubQRemoveRelBuilder, int, int, boolean, boolean) At HiveSubQueryRemoveRule.java:[line 180] | | | Switch statement found in org.apache.hadoop.hive.ql.optimizer.calcite.rules.HiveSubQueryRemoveRule.apply(RelMetadataQuery, RexSubQuery, Set, RelOptUtil$Logic, HiveSubQRemoveRelBuilder, int, int, boolean, boolean) where one case falls through to the next case At HiveSubQueryRemoveRule.java:RexSubQuery, Set, RelOptUtil$Logic, HiveSubQRemoveRelBuilder, int, int, boolean, boolean) where one case falls through to the next case At HiveSubQueryRemoveRule.java:[lines 434-437] | | | Switch statement found in org.apache.hadoop.hive.ql.optimizer.calcite.rules.HiveSubQueryRemoveRule.apply(RelMetadataQuery, RexSubQuery, Set, RelOptUtil$Logic, HiveSubQRemoveRelBuilder, int, int, boolean, boolean) where default case is missing At HiveSubQueryRemoveRule.java:RexSubQuery, Set, RelOptUtil$Logic, HiveSubQRemoveRelBuilder, int, int, boolean, boolean) where default case is missing At HiveSubQueryRemoveRule.java:[lines 294-325] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-16750/dev-support/hive-personality.sh | | git revision | master / 1eb3194 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-16750/yetus/diff-checkstyle-ql.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-16750/yetus/new-findbugs-ql.html | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-16750/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Scalar query rewrite could be improved to not generate an extra join if > subquery is guaranteed to produce atmost one row > ------------------------------------------------------------------------------------------------------------------------ > > Key: HIVE-21537 > URL: https://issues.apache.org/jira/browse/HIVE-21537 > Project: Hive > Issue Type: Improvement > Components: Query Planning > Affects Versions: 4.0.0 > Reporter: Vineet Garg > Assignee: Vineet Garg > Priority: Major > Labels: sub-query > Attachments: HIVE-21537.1.patch > > > Currently Hive planner introduces this branch and later executes a rule to > remove this branch if it could. > Subquery remove rule itself could check if subquery will produce max one row > (using relmetadat's getMaxRowCount) and avoid introducing this branch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)