[ https://issues.apache.org/jira/browse/HIVE-21543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805438#comment-16805438 ]
Hive QA commented on HIVE-21543: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 42s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 33s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 6s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 34s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 45s{color} | {color:blue} standalone-metastore/metastore-common in master has 29 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 18s{color} | {color:blue} standalone-metastore/metastore-server in master has 179 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 22s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 12s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 6s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 13s{color} | {color:red} standalone-metastore/metastore-common: The patch generated 4 new + 194 unchanged - 0 fixed = 198 total (was 194) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 3s{color} | {color:red} standalone-metastore/metastore-common generated 1 new + 29 unchanged - 0 fixed = 30 total (was 29) {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 1m 3s{color} | {color:red} standalone-metastore_metastore-common generated 2 new + 49 unchanged - 0 fixed = 51 total (was 49) {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 26m 17s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:standalone-metastore/metastore-common | | | org.apache.hadoop.hive.metastore.utils.FilterUtils.filterCompactionsIfEnabled(boolean, MetaStoreFilterHook, String, List) makes inefficient use of keySet iterator instead of entrySet iterator At FilterUtils.java:inefficient use of keySet iterator instead of entrySet iterator At FilterUtils.java:[line 428] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-16761/dev-support/hive-personality.sh | | git revision | master / 23ab7f2 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-16761/yetus/diff-checkstyle-standalone-metastore_metastore-common.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-16761/yetus/new-findbugs-standalone-metastore_metastore-common.html | | javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-16761/yetus/diff-javadoc-javadoc-standalone-metastore_metastore-common.txt | | modules | C: standalone-metastore/metastore-common standalone-metastore/metastore-server U: standalone-metastore | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-16761/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Use FilterHooks for show compactions > ------------------------------------ > > Key: HIVE-21543 > URL: https://issues.apache.org/jira/browse/HIVE-21543 > Project: Hive > Issue Type: Improvement > Reporter: Peter Vary > Assignee: Peter Vary > Priority: Major > Attachments: HIVE-21543.01.patch > > > Use FilterHooks for checking dbs/tables/partitions for showCompactions -- This message was sent by Atlassian JIRA (v7.6.3#76005)