[
https://issues.apache.org/jira/browse/HIVE-21279?focusedWorklogId=221471&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221471
]
ASF GitHub Bot logged work on HIVE-21279:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/19 20:52
Start Date: 01/Apr/19 20:52
Worklog Time Spent: 10m
Work Description: jdere commented on pull request #582: Hive 21386:
Extend the fetch task enhancement done in HIVE-21279 to make it work with query
result cache
URL: https://github.com/apache/hive/pull/582#discussion_r271045710
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/cache/results/QueryResultsCache.java
##########
@@ -555,20 +558,20 @@ public boolean setEntryValid(CacheEntry cacheEntry,
FetchWork fetchWork) {
return false;
}
- if (requiresMove) {
- // Move the query results to the query cache directory.
- cachedResultsPath = moveResultsToCacheDirectory(queryResultsPath);
- dataDirMoved = true;
+ if (requiresCaching) {
+ cacheEntry.cachedResultPaths = new HashSet<>();
+ for(FileStatus fs:fetchWork.getFilesToFetch()) {
+ cacheEntry.cachedResultPaths.add(fs);
+ }
}
- LOG.info("Moved query results from {} to {} (size {}) for query '{}'",
Review comment:
It might be useful to keep the logging statement which gives the size of the
results cache entry that was created here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 221471)
Time Spent: 1h (was: 50m)
> Avoid moving/rename operation in FileSink op for SELECT queries
> ---------------------------------------------------------------
>
> Key: HIVE-21279
> URL: https://issues.apache.org/jira/browse/HIVE-21279
> Project: Hive
> Issue Type: Improvement
> Components: Query Planning
> Reporter: Vineet Garg
> Assignee: Vineet Garg
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-21279.1.patch, HIVE-21279.10.patch,
> HIVE-21279.11.patch, HIVE-21279.12.patch, HIVE-21279.13.patch,
> HIVE-21279.2.patch, HIVE-21279.3.patch, HIVE-21279.4.patch,
> HIVE-21279.5.patch, HIVE-21279.6.patch, HIVE-21279.7.patch,
> HIVE-21279.8.patch, HIVE-21279.9.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Currently at the end of a job FileSink operator moves/rename temp directory
> to another directory from which FetchTask fetches result. This is done to
> avoid fetching potential partial/invalid files by failed/runway tasks. This
> operation is expensive for cloud storage. It could be avoided if FetchTask is
> passed on set of files to read from instead of whole directory.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
