[
https://issues.apache.org/jira/browse/HIVE-21529?focusedWorklogId=227206&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-227206
]
ASF GitHub Bot logged work on HIVE-21529:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Apr/19 17:38
Start Date: 13/Apr/19 17:38
Worklog Time Spent: 10m
Work Description: sankarh commented on pull request #581: HIVE-21529 :
Bootstrap ACID tables as part of incremental dump.
URL: https://github.com/apache/hive/pull/581#discussion_r275126178
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpWork.java
##########
@@ -65,11 +65,20 @@ int maxEventLimit() throws Exception {
return maxEventLimit;
}
- void overrideEventTo(Hive fromDb) throws Exception {
+ void overrideEventTo(Hive fromDb, long bootstrapLastId) throws Exception {
if (eventTo == null) {
eventTo = fromDb.getMSC().getCurrentNotificationEventId().getEventId();
LoggerFactory.getLogger(this.getClass())
.debug("eventTo not specified, using current event id : {}",
eventTo);
}
+
+ // If we are bootstrapping ACID tables, we need to restrict events only
upto the event id at
+ // the beginning of the bootstrap dump. See bootstrampDump() for more
details.
+ if (bootstrapLastId >= 0) {
Review comment:
bootstrapLastId should not be 0 also. Shall check (bootstrapLastId > 0)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 227206)
Time Spent: 3h 50m (was: 3h 40m)
> Hive support bootstrap of ACID/MM tables on an existing policy.
> ---------------------------------------------------------------
>
> Key: HIVE-21529
> URL: https://issues.apache.org/jira/browse/HIVE-21529
> Project: Hive
> Issue Type: Sub-task
> Components: repl, Transactions
> Affects Versions: 4.0.0
> Reporter: Sankar Hariappan
> Assignee: Ashutosh Bapat
> Priority: Major
> Labels: DR, pull-request-available, replication
> Attachments: HIVE-21529.01.patch, HIVE-21529.02.patch,
> HIVE-21529.03.patch
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> If ACID/MM tables to be enabled (hive.repl.dump.include.acid.tables) on an
> existing repl policy, then need to combine bootstrap dump of these tables
> along with the ongoing incremental dump.
> Shall add a one time config "hive.repl.bootstrap.acid.tables" to include
> bootstrap in the given dump.
> The support for hive.repl.bootstrap.cleanup.type for ACID tables to clean-up
> partially bootstrapped tables in case of retry is already in place, thanks to
> the work done during external tables. Need to test that it actually works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
