[
https://issues.apache.org/jira/browse/HIVE-21240?focusedWorklogId=230697&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-230697
]
ASF GitHub Bot logged work on HIVE-21240:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Apr/19 13:45
Start Date: 22/Apr/19 13:45
Worklog Time Spent: 10m
Work Description: BELUGABEHR commented on pull request #530: HIVE-21240:
JSON SerDe Deserialize Re-Write
URL: https://github.com/apache/hive/pull/530#discussion_r277294129
##########
File path: serde/src/java/org/apache/hadoop/hive/serde2/JsonSerDe.java
##########
@@ -142,227 +197,21 @@ public Object deserialize(Writable blob) throws
SerDeException {
* and generate a Text representation of the object.
*/
@Override
- public Writable serialize(Object obj, ObjectInspector objInspector)
- throws SerDeException {
- StringBuilder sb = new StringBuilder();
- try {
+ public Writable serialize(final Object obj,
Review comment:
I just checked this... this is the correct format when using the Hadoop
check-style format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 230697)
Time Spent: 1.5h (was: 1h 20m)
> JSON SerDe Re-Write
> -------------------
>
> Key: HIVE-21240
> URL: https://issues.apache.org/jira/browse/HIVE-21240
> Project: Hive
> Issue Type: Improvement
> Components: Serializers/Deserializers
> Affects Versions: 4.0.0, 3.1.1
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-21240.1.patch, HIVE-21240.1.patch,
> HIVE-21240.10.patch, HIVE-21240.11.patch, HIVE-21240.11.patch,
> HIVE-21240.11.patch, HIVE-21240.11.patch, HIVE-21240.2.patch,
> HIVE-21240.3.patch, HIVE-21240.4.patch, HIVE-21240.5.patch,
> HIVE-21240.6.patch, HIVE-21240.7.patch, HIVE-21240.9.patch,
> HIVE-24240.8.patch, kafka_storage_handler.diff
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The JSON SerDe has a few issues, I will link them to this JIRA.
> * Use Jackson Tree parser instead of manually parsing
> * Added support for base-64 encoded data (the expected format when using JSON)
> * Added support to skip blank lines (returns all columns as null values)
> * Current JSON parser accepts, but does not apply, custom timestamp formats
> in most cases
> * Added some unit tests
> * Added cache for column-name to column-index searches, currently O\(n\) for
> each row processed, for each column in the row
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
