[ 
https://issues.apache.org/jira/browse/HIVE-21661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829694#comment-16829694
 ] 

Hive QA commented on HIVE-21661:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12967397/HIVE-21661.2.patch

{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 15934 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/17071/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17071/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17071/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12967397 - PreCommit-HIVE-Build

> Add option to check q file syntax before execution
> --------------------------------------------------
>
>                 Key: HIVE-21661
>                 URL: https://issues.apache.org/jira/browse/HIVE-21661
>             Project: Hive
>          Issue Type: Improvement
>          Components: Testing Infrastructure
>            Reporter: Bruno Pusztahazi
>            Assignee: Bruno Pusztahazi
>            Priority: Major
>         Attachments: HIVE-21661.1.patch, HIVE-21661.2.patch
>
>
> Currently q file tests are executed line-by-line. This could lead to 
> problems, e.g. when a q file has some long running queries and the last line 
> contains a syntax error. In this case everything before the wrong line will 
> be executed first, which could take a lot of time and only then will the test 
> fail due to the syntax error.
> I propose a simple syntax checker that will check the q file for errors 
> before executing any statements. This check can will be turned off by default 
> and can be enabled with the following option: 
> {code:java}
> -Dtest.check.syntax=true{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to