[
https://issues.apache.org/jira/browse/HIVE-21365?focusedWorklogId=243753&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-243753
]
ASF GitHub Bot logged work on HIVE-21365:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/19 00:15
Start Date: 17/May/19 00:15
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #630: HIVE-21365
URL: https://github.com/apache/hive/pull/630#discussion_r284941818
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveAggregateJoinTransposeRule.java
##########
@@ -63,20 +66,16 @@
*/
public class HiveAggregateJoinTransposeRule extends AggregateJoinTransposeRule
{
- /** Extended instance of the rule that can push down aggregate functions. */
- public static final HiveAggregateJoinTransposeRule INSTANCE =
- new HiveAggregateJoinTransposeRule(HiveAggregate.class, HiveJoin.class,
- HiveRelFactories.HIVE_BUILDER, true);
+ private static final Logger LOG =
LoggerFactory.getLogger(HiveAggregateJoinTransposeRule.class);
private final boolean allowFunctions;
+ private final AtomicInteger noColsMissingStats;
/** Creates an AggregateJoinTransposeRule that may push down functions. */
- private HiveAggregateJoinTransposeRule(Class<? extends Aggregate>
aggregateClass,
- Class<? extends Join> joinClass,
- RelBuilderFactory relBuilderFactory,
- boolean allowFunctions) {
- super(aggregateClass, joinClass, relBuilderFactory, true);
- this.allowFunctions = allowFunctions;
+ public HiveAggregateJoinTransposeRule(AtomicInteger noColsMissingStats) {
Review comment:
Since ```AtomicInteger``` needs to be passed as a parameter from
```CalcitePlanner```, this cannot be a static final instance anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 243753)
Time Spent: 1h (was: 50m)
> Refactor Hep planner steps in CBO
> ---------------------------------
>
> Key: HIVE-21365
> URL: https://issues.apache.org/jira/browse/HIVE-21365
> Project: Hive
> Issue Type: Improvement
> Components: CBO
> Reporter: Jesus Camacho Rodriguez
> Assignee: Jesus Camacho Rodriguez
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21365.01.patch, HIVE-21365.01.patch,
> HIVE-21365.02.patch, HIVE-21365.03.patch, HIVE-21365.03.patch,
> HIVE-21365.04.patch, HIVE-21365.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Using subprograms to decrease number of planner instantiations and benefit
> fully from metadata providers caching, among other benefits.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
