[ 
https://issues.apache.org/jira/browse/HIVE-21742?focusedWorklogId=253399&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-253399
 ]

ASF GitHub Bot logged work on HIVE-21742:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Jun/19 21:50
            Start Date: 03/Jun/19 21:50
    Worklog Time Spent: 10m 
      Work Description: vineetgarg02 commented on pull request #656: HIVE-21742 
: Vectorization: CASE result type casting
URL: https://github.com/apache/hive/pull/656#discussion_r290013915
 
 

 ##########
 File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
 ##########
 @@ -571,7 +571,7 @@ private RexNode handleExplicitCast(ExprNodeGenericFuncDesc 
func, List<RexNode> c
    * If a CASE has branches with string/int/boolean branch types; there is no 
common type.
    */
   private List<RexNode> adjustCaseBranchTypes(List<RexNode> nodes, RelDataType 
retType) {
-    List<RelDataType> branchTypes = new ArrayList<>();
 
 Review comment:
   Removing it. I'll update the pull request.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 253399)
    Time Spent: 2.5h  (was: 2h 20m)

> Vectorization: CASE result type casting
> ---------------------------------------
>
>                 Key: HIVE-21742
>                 URL: https://issues.apache.org/jira/browse/HIVE-21742
>             Project: Hive
>          Issue Type: Bug
>          Components: Logical Optimizer, Vectorization
>    Affects Versions: 3.1.1
>            Reporter: Gopal V
>            Assignee: Vineet Garg
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21742.1.patch, HIVE-21742.2.patch, 
> HIVE-21742.3.patch, HIVE-21742.4.patch
>
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> {code}
> create temporary table foo(q548284 int);
> insert into foo values(1),(2),(3),(4),(5),(6);
> select q548284, CASE WHEN ((q548284 = 1)) THEN (0.2) WHEN ((q548284 = 2)) 
> THEN (0.4) WHEN ((q548284 = 3)) THEN (0.6) WHEN ((q548284 = 4)) THEN (0.8) 
> WHEN ((q548284 = 5)) THEN (1) ELSE (null) END from foo order by q548284 limit 
> 1;
> {code}
> Fails with 
> {code}
> Caused by: java.lang.ClassCastException: 
> org.apache.hadoop.hive.ql.exec.vector.LongColumnVector cannot be cast to 
> org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector
>         at 
> org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector.setElement(DecimalColumnVector.java:130)
>         at 
> org.apache.hadoop.hive.ql.exec.vector.expressions.IfExprColumnNull.evaluate(IfExprColumnNull.java:101)
> {code}
> This gets fixed if the case return of (1) is turned into a (1.0).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to