[ https://issues.apache.org/jira/browse/HIVE-21835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857102#comment-16857102 ]
Hive QA commented on HIVE-21835: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12970935/HIVE-21835.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 16079 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/17439/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17439/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17439/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12970935 - PreCommit-HIVE-Build > Unnecessary null checks in org.apache.hadoop.hive.ql.optimizer.StatsOptimizer > ----------------------------------------------------------------------------- > > Key: HIVE-21835 > URL: https://issues.apache.org/jira/browse/HIVE-21835 > Project: Hive > Issue Type: Improvement > Reporter: Ivan Suller > Assignee: Ivan Suller > Priority: Minor > Attachments: HIVE-21835.1.patch > > > There are several null checks in > org.apache.hadoop.hive.ql.optimizer.StatsOptimizer after Long.parseLong(...) > call. This method returns with a primitive long value, which cannot be null - > a null check after this call is redundant. -- This message was sent by Atlassian JIRA (v7.6.3#76005)