[ https://issues.apache.org/jira/browse/HIVE-21816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858458#comment-16858458 ]
Hive QA commented on HIVE-21816: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12971092/HIVE-21816.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 16044 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/17468/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17468/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17468/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12971092 - PreCommit-HIVE-Build > HMS Translation: Refactor tests to work with ACID tables. > --------------------------------------------------------- > > Key: HIVE-21816 > URL: https://issues.apache.org/jira/browse/HIVE-21816 > Project: Hive > Issue Type: Sub-task > Components: Hive > Affects Versions: 4.0.0 > Reporter: Naveen Gangam > Assignee: Naveen Gangam > Priority: Major > Attachments: HIVE-21816.patch, HIVE-21816.patch, HIVE-21816.patch, > HIVE-21816.patch, HIVE-21816.patch, HIVE-21816.patch > > > 1) TestHiveMetaStore unit tests does not work for full ACID tables as the > TransactionalValidationListener enforces that this table use AcidIO. The Orc > IO files are only included in the hive-exec jars that are not used by tests > under standalone-metastore module. Even adding a test-scoped dependency on > hive-exec did not work. I had to relocate these tests into itests. > 2) Implementation of logic that allows skipping of translation via the use of > "MANAGERAWMETADATA" capability. > 3) Fixed some test bugs as the test was not failing originally when the > createTable failed because of the issue in #1. As a result, about 3 tests > never ran fully and never failed. The tests now fail if there are issues. > 4) Refactoring of the code in the DefaultTransformer to make static lists of > capabilities. The return capabilities now is dependent on the table > capabilities, the processor capabilities and the accessType assigned to the > table. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)