[
https://issues.apache.org/jira/browse/HIVE-21841?focusedWorklogId=261189&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-261189
]
ASF GitHub Bot logged work on HIVE-21841:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jun/19 06:38
Start Date: 17/Jun/19 06:38
Worklog Time Spent: 10m
Work Description: ashutosh-bapat commented on pull request #668:
HIVE-21841 : Add configuration to specify the hostname of HMS leader …to run
housekeeping tasks in.
URL: https://github.com/apache/hive/pull/668#discussion_r294152137
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/MetastoreTaskThreadTestImpl1.java
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.metastore;
+
+import org.apache.hadoop.conf.Configuration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.concurrent.TimeUnit;
+
+/**
+ * An implementation of MetastoreTaskThread for testing metastore leader
config.
+ */
+public class MetastoreTaskThreadTestImpl1 implements MetastoreTaskThread {
Review comment:
It's not about TASK_NAME really. That's just an indicator. What we really
need to test is loading a class and creating a thread when it's specified in
config. For that we need different loadable classes. We could have created a
base class and extended it but that adds one more class and there's nothing
much value in de-duplicating the code. We do not duplicate the code to avoid
hazards of duplicating the code like bug fixes, changes at multiple places.
Nothing of that sort is possible here. Further, having the code duplicated
gives future flexibility to change code in each of those classes like changing
runFrequency() or actual run() implementation, which is more desirable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 261189)
Time Spent: 2h 20m (was: 2h 10m)
> Leader election in HMS to run housekeeping tasks.
> -------------------------------------------------
>
> Key: HIVE-21841
> URL: https://issues.apache.org/jira/browse/HIVE-21841
> Project: Hive
> Issue Type: New Feature
> Affects Versions: 4.0.0
> Reporter: Ashutosh Bapat
> Assignee: Ashutosh Bapat
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-21841.01.patch, HIVE-21841.02.patch
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> HMS performs housekeeping tasks. When there are multiple HMSes we need to
> have a leader HMS elected which will carry out those housekeeping tasks.
> These tasks include execution of compaction tasks, auto-discovering
> partitions for external tables, generation of compaction tasks, repl thread
> etc.
> Note that, though the code for compaction tasks, auto-discovery of partitions
> etc. is in Hive, the actual tasks are initiated by an HMS configured to do
> so. So, leader election is required only for HMS and not for HS2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
