[
https://issues.apache.org/jira/browse/HIVE-21576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865405#comment-16865405
]
Hive QA commented on HIVE-21576:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m
3s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
42s{color} | {color:blue} common in master has 62 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
30s{color} | {color:blue} ql in master has 2260 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
22s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
33s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
41s{color} | {color:red} ql generated 23 new + 2238 unchanged - 22 fixed = 2261
total (was 2260) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 32m 52s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Switch statement found in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.castExpression()
where default case is missing At HiveParser_IdentifiersParser.java:where
default case is missing At HiveParser_IdentifiersParser.java:[lines 3968-3976]
|
| | Dead store to LA31_100 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33396] |
| | Dead store to LA31_101 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33409] |
| | Dead store to LA31_102 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33422] |
| | Dead store to LA31_15 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33292] |
| | Dead store to LA31_16 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33305] |
| | Dead store to LA31_17 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33318] |
| | Dead store to LA31_18 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33331] |
| | Dead store to LA31_19 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33344] |
| | Dead store to LA31_97 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33357] |
| | Dead store to LA31_98 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33370] |
| | Dead store to LA31_99 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33383] |
| | Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32
be a _static_ inner class? At HiveParser_IdentifiersParser.java:inner class?
At HiveParser_IdentifiersParser.java:[lines 33568-33581] |
| | Dead store to LA36_169 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA36.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA36.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33868] |
| | Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA38
be a _static_ inner class? At HiveParser_IdentifiersParser.java:inner class?
At HiveParser_IdentifiersParser.java:[lines 35078-35091] |
| | Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA47
be a _static_ inner class? At HiveParser_IdentifiersParser.java:inner class?
At HiveParser_IdentifiersParser.java:[lines 35999-36012] |
| | Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA51
be a _static_ inner class? At HiveParser_IdentifiersParser.java:inner class?
At HiveParser_IdentifiersParser.java:[lines 36488-36501] |
| | Dead store to LA54_48 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 36746] |
| | Dead store to LA54_56 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 36759] |
| | Dead store to LA54_57 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 36772] |
| | Dead store to LA54_58 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 36785] |
| | Dead store to LA54_59 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 36798] |
| | org.apache.hadoop.hive.ql.udf.generic.GenericUDFCastFormat is
Serializable; consider declaring a serialVersionUID At
GenericUDFCastFormat.java:a serialVersionUID At
GenericUDFCastFormat.java:[lines 64-250] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-17605/dev-support/hive-personality.sh
|
| git revision | master / 2947a1f |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17605/yetus/new-findbugs-ql.html
|
| modules | C: common ql U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-17605/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Introduce CAST...FORMAT and limited list of SQL:2016 datetime formats
> ---------------------------------------------------------------------
>
> Key: HIVE-21576
> URL: https://issues.apache.org/jira/browse/HIVE-21576
> Project: Hive
> Issue Type: Improvement
> Reporter: Karen Coppage
> Assignee: Karen Coppage
> Priority: Major
> Attachments: HIVE-21576.01.patch, HIVE-21576.03.patch,
> HIVE-21576.04.patch, HIVE-21576.05.patch, HIVE-21576.06.patch,
> HIVE-21576.07.patch, HIVE-21576.08.patch, HIVE-21576.09.patch,
> HIVE-21576.10.patch, HIVE-21576.11.patch, HIVE-21576.12.patch,
> HIVE-21576.13.patch, HIVE-21576.14.patch, HIVE-21576.15.patch,
> HIVE-21576.16.patch, HIVE-21576.2.patch
>
>
> Introduce FORMAT clause to CAST statements as well as the below limited list
> of SQL:2016 datetime formats to Hive in general.
> * YYYY
> * MM
> * DD
> * HH
> * MI
> * SS
> * YYY
> * YY
> * Y
> * RRRR
> * RR
> * DDD
> * HH12
> * HH24
> * SSSSS
> * FF[1..9]
> * AM/A.M.
> * PM/P.M.
> * TZH
> * TZM
> Definitions of these formats here:
> [https://docs.google.com/document/d/1V7k6-lrPGW7_uhqM-FhKl3QsxwCRy69v2KIxPsGjc1k/|https://docs.google.com/document/d/1V7k6-lrPGW7_uhqM-FhKl3QsxwCRy69v2KIxPsGjc1k/edit]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
