[ https://issues.apache.org/jira/browse/HIVE-21764?focusedWorklogId=264545&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-264545 ]
ASF GitHub Bot logged work on HIVE-21764: ----------------------------------------- Author: ASF GitHub Bot Created on: 21/Jun/19 11:22 Start Date: 21/Jun/19 11:22 Worklog Time Spent: 10m Work Description: sankarh commented on pull request #679: HIVE-21764 : REPL DUMP should detect and bootstrap any rename table events where old table was excluded but renamed table is included. URL: https://github.com/apache/hive/pull/679#discussion_r296197082 ########## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/Utils.java ########## @@ -214,29 +215,35 @@ public static boolean shouldReplicate(ReplicationSpec replicationSpec, Table tab return false; } - // Skip dumping events related to ACID tables if bootstrap is enabled on it. - // Also, skip if current table is included only in new policy but not in old policy. - if (isEventDump) { - return !hiveConf.getBoolVar(HiveConf.ConfVars.REPL_BOOTSTRAP_ACID_TABLES) - && ReplUtils.tableIncludedInReplScope(oldReplScope, tableHandle.getTableName()); + // Skip dumping events related to ACID tables if bootstrap is enabled for ACID tables. + if (isEventDump && hiveConf.getBoolVar(HiveConf.ConfVars.REPL_BOOTSTRAP_ACID_TABLES)) { + return false; } } - // If replication policy is replaced with new included/excluded tables list, then events - // corresponding to tables which are not included in old policy but included in new policy - // should be skipped. Those tables would be bootstrapped along with the current incremental - // replication dump. - // Note: If any event dump reaches here, it means, table is included in new replication policy. - if (isEventDump && !ReplUtils.tableIncludedInReplScope(oldReplScope, tableHandle.getTableName())) { - return false; + // Tables which are selected for bootstrap should be skipped. Those tables would be bootstrapped + // along with the current incremental replication dump and thus no need to dump events for them. + // Note: If any event (other than alter table with table level replication) dump reaches here, it means, table is + // included in new replication policy. + if (isEventDump) { + // If replication policy is replaced with new included/excluded tables list, then events + // corresponding to tables which are not included in old policy but included in new policy + // should be skipped. + if (!ReplUtils.tableIncludedInReplScope(oldReplScope, tableHandle.getTableName())) { + return false; + } + + // Tables in the list of tables to be bootstrapped should be skipped. Review comment: I meant, "Events are skipped not tables." ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 264545) Time Spent: 4h 10m (was: 4h) > REPL DUMP should detect and bootstrap any rename table events where old table > was excluded but renamed table is included. > ------------------------------------------------------------------------------------------------------------------------- > > Key: HIVE-21764 > URL: https://issues.apache.org/jira/browse/HIVE-21764 > Project: Hive > Issue Type: Sub-task > Components: repl > Reporter: Sankar Hariappan > Assignee: mahesh kumar behera > Priority: Major > Labels: DR, Replication, pull-request-available > Attachments: HIVE-21764.01.patch, HIVE-21764.02.patch > > Time Spent: 4h 10m > Remaining Estimate: 0h > > REPL DUMP fetches the events from NOTIFICATION_LOG table based on regular > expression + inclusion/exclusion list. So, in case of rename table event, the > event will be ignored if old table doesn't match the pattern but the new > table should be bootstrapped. REPL DUMP should have a mechanism to detect > such tables and automatically bootstrap with incremental replication.Also, if > renamed table is excluded from replication policy, then need to drop the old > table at target as well. > There are 4 scenarios that needs to be handled. > # Both new name and old name satisfies the table name pattern filter. > ## No need to do anything. The incremental event for rename should take care > of the replication. > # Both the names does not satisfy the table name pattern filter. > ## Both the names are not in the scope of the policy and thus nothing needs > to be done. > # New name satisfies the pattern but the old name does not. > ## The table will not be present at the target. > ## Rename event handler for dump should detect this case and add the new > table name to the list of table for bootstrap. > ## All the events related to the table (new name) should be ignored. > ## If there is a drop event for the table (with new name), then remove the > table from the list of tables to be bootstrapped. > ## In case of rename (double rename) > ### If the new name satisfies the table pattern, then add the new name to > the list of tables to be bootstrapped and remove the old name from the list > of tables to be bootstrapped. > ### If the new name does not satisfies then just removed the table name from > the list of tables to be bootstrapped. > # New name does not satisfies the pattern but the old name satisfies. > ## Change the rename event to a drop event. -- This message was sent by Atlassian JIRA (v7.6.3#76005)