[ https://issues.apache.org/jira/browse/HIVE-21896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16869480#comment-16869480 ]
Hive QA commented on HIVE-21896: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 3s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 4s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 43s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 11s{color} | {color:blue} ql in master has 2254 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 0s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 44s{color} | {color:green} ql: The patch generated 0 new + 292 unchanged - 1 fixed = 292 total (was 293) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 25m 33s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-17687/dev-support/hive-personality.sh | | git revision | master / 9890919 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-17687/yetus/whitespace-eol.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-17687/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > SHOW FUNCTIONS / SHOW FUNCTIONS LIKE - clarify > ---------------------------------------------- > > Key: HIVE-21896 > URL: https://issues.apache.org/jira/browse/HIVE-21896 > Project: Hive > Issue Type: Bug > Components: Hive > Affects Versions: 3.1.1 > Reporter: Miklos Gergely > Assignee: Miklos Gergely > Priority: Major > Labels: incompatibleChange, todoc4.0 > Fix For: 4.0.0 > > Attachments: HIVE-21896.01.patch > > > According to > [https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-ShowFunctions] > the currently available functions can be listed like this: > {code:java} > SHOW FUNCTIONS <pattern>;{code} > If the user executes this command, they will get the correct list of > functions, but they will also see this on the standard output: > {code:java} > SHOW FUNCTIONS is deprecated, please use SHOW FUNCTIONS LIKE instead.{code} > If the user uses the > {code:java} > SHOW FUNCTIONS LIKE <pattern>;{code} > command then they will receive the exact same result (though through > different codes). The only difference is that one can get all the function > names with "SHOW FUNCTIONS;", while "SHOW FUNCTIONS LIKE;" returns an > exception, so in this case the pattern is mandatory. > So there should be a decision if we still accept "SHOW FUNCTIONS" without the > "LIKE". My suggestion is to accept it only if there is no pattern. so "SHOW > FUNCTIONS;" is ok, without deprecation message, but "SHOW FUNCTIONS > <pattern>" should throw an exception. > Whatever we decide, we should document it appropriately. > cc [~krishahn] -- This message was sent by Atlassian JIRA (v7.6.3#76005)