[ https://issues.apache.org/jira/browse/HIVE-21846?focusedWorklogId=265788&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-265788 ]
ASF GitHub Bot logged work on HIVE-21846: ----------------------------------------- Author: ASF GitHub Bot Created on: 24/Jun/19 16:17 Start Date: 24/Jun/19 16:17 Worklog Time Spent: 10m Work Description: odraese commented on pull request #683: HIVE-21846: Create a thread in TezAM which periodically fetches LlapDaemon metrics URL: https://github.com/apache/hive/pull/683#discussion_r296803805 ########## File path: llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java ########## @@ -790,6 +794,8 @@ public void run() { } }, 0, 10000L, TimeUnit.MILLISECONDS); + llapMetricsCollector.start(); Review comment: Should we maybe move the start below the code, adding the collector to the registry? Otherwise, the collector doesn't have any LLAP daemons and the first scheduler execution is a NOOP.... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 265788) Time Spent: 40m (was: 0.5h) > Create a thread in TezAM which periodically fetches LlapDaemon metrics > ---------------------------------------------------------------------- > > Key: HIVE-21846 > URL: https://issues.apache.org/jira/browse/HIVE-21846 > Project: Hive > Issue Type: Sub-task > Components: llap, Tez > Reporter: Peter Vary > Assignee: Antal Sinkovits > Priority: Major > Labels: pull-request-available > Attachments: HIVE-21846.01.patch > > Time Spent: 40m > Remaining Estimate: 0h > > LlapTaskSchedulerService should start a thread which periodically fetches the > LlapDaemon metrics and stores them in the NodeInfo object. > This should be just the first implementation - later we should find a way > where we do not need NxM requests between N TezAM and M LlapDaemon -- This message was sent by Atlassian JIRA (v7.6.3#76005)