[ https://issues.apache.org/jira/browse/HIVE-17593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872827#comment-16872827 ]
Hive QA commented on HIVE-17593: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12931657/HIVE-17593.5.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 19 failed/errored test(s), 16340 tests executed *Failed tests:* {noformat} org.apache.hive.hcatalog.api.TestHCatClient.testBasicDDLCommands (batchId=206) org.apache.hive.hcatalog.api.TestHCatClient.testCreateTableLike (batchId=206) org.apache.hive.hcatalog.api.TestHCatClient.testDatabaseLocation (batchId=206) org.apache.hive.hcatalog.api.TestHCatClient.testDropPartitionsWithPartialSpec (batchId=206) org.apache.hive.hcatalog.api.TestHCatClient.testDropTableException (batchId=206) org.apache.hive.hcatalog.api.TestHCatClient.testEmptyTableInstantiation (batchId=206) org.apache.hive.hcatalog.api.TestHCatClient.testGetMessageBusTopicName (batchId=206) org.apache.hive.hcatalog.api.TestHCatClient.testGetPartitionsWithPartialSpec (batchId=206) org.apache.hive.hcatalog.api.TestHCatClient.testObjectNotFoundException (batchId=206) org.apache.hive.hcatalog.api.TestHCatClient.testOtherFailure (batchId=206) org.apache.hive.hcatalog.api.TestHCatClient.testPartitionRegistrationWithCustomSchema (batchId=206) org.apache.hive.hcatalog.api.TestHCatClient.testPartitionSchema (batchId=206) org.apache.hive.hcatalog.api.TestHCatClient.testPartitionSpecRegistrationWithCustomSchema (batchId=206) org.apache.hive.hcatalog.api.TestHCatClient.testPartitionsHCatClientImpl (batchId=206) org.apache.hive.hcatalog.api.TestHCatClient.testRenameTable (batchId=206) org.apache.hive.hcatalog.api.TestHCatClient.testReplicationTaskIter (batchId=206) org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation (batchId=206) org.apache.hive.hcatalog.api.TestHCatClient.testTransportFailure (batchId=206) org.apache.hive.hcatalog.api.TestHCatClient.testUpdateTableSchema (batchId=206) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/17738/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17738/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17738/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 19 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12931657 - PreCommit-HIVE-Build > DataWritableWriter strip spaces for CHAR type before writing, but predicate > generator doesn't do same thing. > ------------------------------------------------------------------------------------------------------------ > > Key: HIVE-17593 > URL: https://issues.apache.org/jira/browse/HIVE-17593 > Project: Hive > Issue Type: Bug > Affects Versions: 2.3.0, 3.0.0 > Reporter: Junjie Chen > Assignee: Junjie Chen > Priority: Major > Labels: pull-request-available > Attachments: HIVE-17593.2.patch, HIVE-17593.3.patch, > HIVE-17593.4.patch, HIVE-17593.5.patch, HIVE-17593.patch > > Time Spent: 10m > Remaining Estimate: 0h > > DataWritableWriter strip spaces for CHAR type before writing. While when > generating predicate, it does NOT do same striping which should cause data > missing! > In current version, it doesn't cause data missing since predicate is not well > push down to parquet due to HIVE-17261. > Please see ConvertAstTosearchArg.java, getTypes treats CHAR and STRING as > same which will build a predicate with tail spaces. -- This message was sent by Atlassian JIRA (v7.6.3#76005)