[
https://issues.apache.org/jira/browse/HIVE-11278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697512#comment-14697512
]
Ashutosh Chauhan commented on HIVE-11278:
-----------------------------------------
[~prongs] Will it be possible to add a test case which fails in absence of this
patch?
> Partition.setOutputFormatClass should not do toString for Class object
> -----------------------------------------------------------------------
>
> Key: HIVE-11278
> URL: https://issues.apache.org/jira/browse/HIVE-11278
> Project: Hive
> Issue Type: Bug
> Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Fix For: 2.0.0
>
> Attachments: HIVE-11278.01.patch
>
>
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java#L286
> inside setInputFormatClass, we're doing:
> {noformat}
> public void setInputFormatClass(Class<? extends InputFormat>
> inputFormatClass) {
> this.inputFormatClass = inputFormatClass;
> tPartition.getSd().setInputFormat(inputFormatClass.getName());
> }
> {noformat}
> But inside setOutputFormatClass, we're doing toString for class, instead of
> getName().
> {noformat}
> public void setOutputFormatClass(Class<? extends HiveOutputFormat>
> outputFormatClass) {
> this.outputFormatClass = outputFormatClass;
> tPartition.getSd().setOutputFormat(HiveFileFormatUtils
> .getOutputFormatSubstitute(outputFormatClass).toString());
> }
> {noformat}
> Difference is that, for Class A.class, toString is "class A.class", getName
> is "A.class". So Class.forName(cls.getName()) succeeds, but
> Class.forName(cls.toString()) is not valid.
> So if you get a partition, set outputformat, and make an alter call, then get
> the partition again and make a getOutputFormatClass call on that object, it
> throws a ClassNotFoundException on
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java#L316,
> because it's basically calling Class.forName("class a.b.c.ClassName.class")
> which is wrong!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
