[ 
https://issues.apache.org/jira/browse/HIVE-21911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876033#comment-16876033
 ] 

Adam Szita commented on HIVE-21911:
-----------------------------------

Hi Peter, patch looks good to me.

I would've added a new constructor with an LlapServiceRegistry parameter in 
LlapMetricsCollector, instead of modifying the original one, but I will leave 
this up to you as there are not too many usages of this class yet.

+1

> Pluggable LlapMetricsListener on Tez side to disable / resize Daemons
> ---------------------------------------------------------------------
>
>                 Key: HIVE-21911
>                 URL: https://issues.apache.org/jira/browse/HIVE-21911
>             Project: Hive
>          Issue Type: Sub-task
>          Components: llap, Tez
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21911.patch
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> We need to have a way to plug in different listeners which act upon the 
> LlapDaemon statistics.
> This listener should be able to disable / resize the LlapDaemons based on 
> health data.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to