[
https://issues.apache.org/jira/browse/HIVE-21912?focusedWorklogId=272076&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-272076
]
ASF GitHub Bot logged work on HIVE-21912:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jul/19 09:29
Start Date: 04/Jul/19 09:29
Worklog Time Spent: 10m
Work Description: pvary commented on pull request #698: HIVE-21912:
Implement DisablingDaemonStatisticsHandler
URL: https://github.com/apache/hive/pull/698#discussion_r300313139
##########
File path:
llap-server/src/test/org/apache/hadoop/hive/llap/registry/impl/TestLlapRegistryService.java
##########
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.llap.registry.impl;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.llap.daemon.MiniLlapCluster;
+import
org.apache.hadoop.hive.llap.registry.impl.LlapZookeeperRegistryImpl.ConfigChangeLockResult;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.assertFalse;
+
+import java.io.IOException;
+
+public class TestLlapRegistryService {
+ private static MiniLlapCluster cluster = null;
+ private static HiveConf conf = new HiveConf();
+
+ @BeforeClass
+ public static void setUp() throws Exception {
+ cluster = MiniLlapCluster.create("llap01", null, 1, 2L, false, false, 1L,
1);
+ HiveConf.setVar(conf, HiveConf.ConfVars.LLAP_DAEMON_XMX_HEADROOM, "1");
+ cluster.serviceInit(conf);
+ cluster.serviceStart();
+ }
+
+ @AfterClass
+ public static void tearDown() throws IOException {
+ if (cluster != null) {
+ cluster.serviceStop();
+ }
+ }
+
+ @Test
+ public void testLockForConfigChange() {
+ LlapRegistryService client1 = new LlapRegistryService(false);
+ client1.init(conf);
+ client1.start();
+
+ LlapRegistryService client2 = new LlapRegistryService(false);
+ client2.init(conf);
+ client2.start();
+ ConfigChangeLockResult result = null;
+
+ assertTrue(client1.lockForConfigChange(10000).success);
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 272076)
Time Spent: 4h 40m (was: 4.5h)
> Implement BlacklistingLlapMetricsListener
> -----------------------------------------
>
> Key: HIVE-21912
> URL: https://issues.apache.org/jira/browse/HIVE-21912
> Project: Hive
> Issue Type: Sub-task
> Components: llap, Tez
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21912.patch, HIVE-21912.wip-2.patch,
> HIVE-21912.wip.patch
>
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> We should implement a DaemonStatisticsHandler which:
> * If a node average response time is bigger than 150% (configurable) of the
> other nodes
> * If the other nodes has enough empty executors to handle the requests
> Then disables the limping node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
