[ https://issues.apache.org/jira/browse/HIVE-21955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878943#comment-16878943 ]
Zihao Ye commented on HIVE-21955: --------------------------------- The failed tests are mostly related to Java version issues rather than this patch. > SearchArgumentImpl generates wrong ExpressionTree in some cases which might > result in loss of data > --------------------------------------------------------------------------------------------------- > > Key: HIVE-21955 > URL: https://issues.apache.org/jira/browse/HIVE-21955 > Project: Hive > Issue Type: Bug > Components: Hive, storage-api > Affects Versions: 1.2.1 > Reporter: Zihao Ye > Assignee: Zihao Ye > Priority: Critical > Labels: pushdown > Attachments: HIVE-21955.1.branch-1.patch, HIVE-21955.branch-1.patch > > > ExpressionBuilder applies `pushDownNot`, `foldMaybe`, `flatten`, > `convertToCNF`, `flatten` and `buildLeafList` in order to form a > non-normalized expression into a CNF expression with the unique leaves. > After an expression is converted to CNF, there might be *more than one > non-leaf nodes which are exactly the same object* in the expression tree. If > this happens, those non-leaf nodes will be visited more than once in > `buildLeafList` function. As a result, a wrong ExpressionTree is generated. > My version is 1.2.1, but it seems that the higher versions are also affected -- This message was sent by Atlassian JIRA (v7.6.3#76005)