[ 
https://issues.apache.org/jira/browse/HIVE-21962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16882637#comment-16882637
 ] 

Hive QA commented on HIVE-21962:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12974134/HIVE-21962.2.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 16618 tests 
executed
*Failed tests:*
{noformat}
TestReplAcrossInstancesWithJsonMessageFormat - did not produce a TEST-*.xml 
file (likely timed out) (batchId=255)
org.apache.hadoop.hive.ql.TestTxnCommandsWithSplitUpdateAndVectorization.testMergeOnTezEdges
 (batchId=324)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/17953/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17953/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17953/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12974134 - PreCommit-HIVE-Build

> Replacing ArrayList params with List in and around PlanUtils and MapWork
> ------------------------------------------------------------------------
>
>                 Key: HIVE-21962
>                 URL: https://issues.apache.org/jira/browse/HIVE-21962
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Ivan Suller
>            Assignee: Ivan Suller
>            Priority: Minor
>         Attachments: HIVE-21962.1.patch, HIVE-21962.1.patch, 
> HIVE-21962.2.patch
>
>
> Using the implementing class is usually a bad practice. OO suggest to use the 
> least restrictive interface instead. ArrayList is used in many-many methods 
> as a parameter - this is just a tiny part of this work.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to