[ 
https://issues.apache.org/jira/browse/HIVE-22003?focusedWorklogId=280696&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-280696
 ]

ASF GitHub Bot logged work on HIVE-22003:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Jul/19 23:26
            Start Date: 22/Jul/19 23:26
    Worklog Time Spent: 10m 
      Work Description: vineetgarg02 commented on pull request #729: HIVE-22003
URL: https://github.com/apache/hive/pull/729#discussion_r306073523
 
 

 ##########
 File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java
 ##########
 @@ -486,6 +510,75 @@ private static boolean 
sharedWorkOptimization(ParseContext pctx, SharedWorkOptim
     return mergedExecuted;
   }
 
+  private static void replaceSemijoinExpressions(TableScanOperator tsOp, 
List<ExprNodeDesc> semijoinExprNodes) {
 
 Review comment:
   So the SJ branch from retainable TS is pushed to discardable TS  so that it 
is later pushed to discardable TS's children filter op? Why do we want to do 
that? Shouldn't retainable SJ be retained with retainable FILTER op only? 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 280696)
    Time Spent: 50m  (was: 40m)

> Shared work optimizer may leave semijoin branches in plan that are not used
> ---------------------------------------------------------------------------
>
>                 Key: HIVE-22003
>                 URL: https://issues.apache.org/jira/browse/HIVE-22003
>             Project: Hive
>          Issue Type: Bug
>          Components: Physical Optimizer
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-22003.01.patch, HIVE-22003.01.patch, 
> HIVE-22003.patch
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> This may happen only when the TS are the only operators that are shared. 
> Repro attached in q file.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to