[
https://issues.apache.org/jira/browse/HIVE-21770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894665#comment-16894665
]
Hive QA commented on HIVE-21770:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m
1s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
37s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m
36s{color} | {color:blue} standalone-metastore/metastore-common in master has
31 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m
9s{color} | {color:blue} standalone-metastore/metastore-server in master has
179 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
8s{color} | {color:blue} ql in master has 2250 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
41s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
25s{color} | {color:blue} testutils/ptest2 in master has 24 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
6s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
58s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
46s{color} | {color:red} ql: The patch generated 17 new + 582 unchanged - 0
fixed = 599 total (was 582) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
14s{color} | {color:red} ql generated 13 new + 2239 unchanged - 11 fixed = 2252
total (was 2250) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
12s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
15s{color} | {color:red} The patch generated 3 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 49m 35s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Self assignment of field ReplDumpWork.partitionFilter in new
org.apache.hadoop.hive.ql.exec.repl.ReplDumpWork(ReplScope, ReplScope, Long,
Long, String, Integer, String) At ReplDumpWork.java:in new
org.apache.hadoop.hive.ql.exec.repl.ReplDumpWork(ReplScope, ReplScope, Long,
Long, String, Integer, String) At ReplDumpWork.java:[line 57] |
| | Uninitialized read of partitionFilter in new
org.apache.hadoop.hive.ql.exec.repl.ReplDumpWork(ReplScope, ReplScope, Long,
Long, String, Integer, String) At ReplDumpWork.java:new
org.apache.hadoop.hive.ql.exec.repl.ReplDumpWork(ReplScope, ReplScope, Long,
Long, String, Integer, String) At ReplDumpWork.java:[line 57] |
| | Should org.apache.hadoop.hive.ql.parse.HiveParser$DFA239 be a _static_
inner class? At HiveParser.java:inner class? At HiveParser.java:[lines
48849-48862] |
| | Dead store to LA31_128 in
org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser.java:org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser.java:[line 48589] |
| | Dead store to LA31_130 in
org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser.java:org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser.java:[line 48602] |
| | Dead store to LA31_132 in
org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser.java:org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser.java:[line 48615] |
| | Dead store to LA31_134 in
org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser.java:org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser.java:[line 48628] |
| | Dead store to LA31_136 in
org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser.java:org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser.java:[line 48641] |
| | Dead store to LA31_138 in
org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser.java:org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser.java:[line 48654] |
| | Dead store to LA31_140 in
org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser.java:org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser.java:[line 48667] |
| | Dead store to LA31_142 in
org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser.java:org.apache.hadoop.hive.ql.parse.HiveParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser.java:[line 48680] |
| | Dead store to LA31_103 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33444] |
| | Dead store to LA36_171 in
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA36.specialStateTransition(int,
IntStream) At
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA36.specialStateTransition(int,
IntStream) At HiveParser_IdentifiersParser.java:[line 33893] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18186/dev-support/hive-personality.sh
|
| git revision | master / 4f7feaa |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18186/yetus/diff-checkstyle-ql.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18186/yetus/whitespace-eol.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18186/yetus/new-findbugs-ql.html
|
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18186/yetus/patch-asflicense-problems.txt
|
| modules | C: standalone-metastore/metastore-common
standalone-metastore/metastore-server ql itests/hive-unit testutils/ptest2 U: .
|
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18186/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Support extraction of replication spec from notification event.
> ----------------------------------------------------------------
>
> Key: HIVE-21770
> URL: https://issues.apache.org/jira/browse/HIVE-21770
> Project: Hive
> Issue Type: Sub-task
> Components: HiveServer2, repl
> Affects Versions: 4.0.0
> Reporter: mahesh kumar behera
> Assignee: mahesh kumar behera
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-21770.01.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The notification event structure currently does not have the partition spec.
> Events which can span across multiple databases and tables, the database and
> table info can not be obtained from the event structure. To know the event is
> added for which partition, the event message has to be deserialized and the
> partition information can be obtained from it.
> * Each event handler has to expose a static API.
> * The API should take the event as input and return the list of db name,
> table name and partition spec from it.
> * If database name, table name or partition name is present in the event
> structure, then return it. If all these info are present then no need to
> deserialize the message. Later if these info are added to the event structure
> then it will be useful.
> * Deserialize the message and create the list of name and return through a
> partition info class object.
> * If the table is not partitioned or is table level event, then set the
> partition info as null. Same for table info incase of db level events.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
