[
https://issues.apache.org/jira/browse/HIVE-21241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16901191#comment-16901191
]
Naveen Gangam commented on HIVE-21241:
--------------------------------------
[~belugabehr] Going forward, could you also post the patch to reviewboard at
reviews.apache.org and post the link here. It is easier to add comments on
reviewboard than here.
Some comments + nits
1) {{LOG.debug("Could not parse timestamp text: {}", text);}}
should this be info instead of debug?
2) Looks like this public static class has been removed, which is fine in a new
release.
public static class MillisDateFormatParser implements DateTimeParser {
Should this be a public class that is visible to everyone given this is not
being used outside this class?
public static class DefaultingTemporalAccessor implements TemporalAccessor {
3) we are removing support for a public constructor.
public TimestampParser(TimestampParser tsParser) {
any chance we can retro-fit this? I am always weary of removing public
constructors .. never know what code, that we are unaware of, has been using it.
Rest looks good.
> Migrate TimeStamp Parser From Joda Time
> ---------------------------------------
>
> Key: HIVE-21241
> URL: https://issues.apache.org/jira/browse/HIVE-21241
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
> Affects Versions: 3.2.0
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-21241.1.patch, HIVE-21241.2.patch,
> HIVE-21241.3.patch, HIVE-21241.4.patch, HIVE-21241.5.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Hive uses Joda time for its TimeStampParser.
> {quote}
> Joda-Time is the de facto standard date and time library for Java prior to
> Java SE 8. Users are now asked to migrate to java.time (JSR-310).
> https://www.joda.org/joda-time/
> {quote}
> Migrate TimeStampParser to {{java.time}}
> I also added a couple new pre-canned timestamp parsers for convenience:
> * ISO 8601
> * RFC 1123
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
