[ 
https://issues.apache.org/jira/browse/HIVE-22083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903261#comment-16903261
 ] 

Hive QA commented on HIVE-22083:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
48s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m  
4s{color} | {color:blue} ql in master has 2250 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
0s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
10s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
44s{color} | {color:red} ql: The patch generated 1 new + 599 unchanged - 53 
fixed = 600 total (was 652) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m 
18s{color} | {color:red} ql generated 4 new + 2237 unchanged - 13 fixed = 2241 
total (was 2250) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
13s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 41s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  org.apache.hadoop.hive.ql.plan.HashTableSinkDesc.getTagOrder() may expose 
internal representation by returning HashTableSinkDesc.tagOrder  At 
HashTableSinkDesc.java:by returning HashTableSinkDesc.tagOrder  At 
HashTableSinkDesc.java:[line 263] |
|  |  org.apache.hadoop.hive.ql.plan.HashTableSinkDesc.setTagOrder(byte[]) may 
expose internal representation by storing an externally mutable object into 
HashTableSinkDesc.tagOrder  At HashTableSinkDesc.java:by storing an externally 
mutable object into HashTableSinkDesc.tagOrder  At HashTableSinkDesc.java:[line 
268] |
|  |  org.apache.hadoop.hive.ql.plan.JoinDesc.getTagOrder() may expose internal 
representation by returning JoinDesc.tagOrder  At JoinDesc.java:by returning 
JoinDesc.tagOrder  At JoinDesc.java:[line 419] |
|  |  org.apache.hadoop.hive.ql.plan.JoinDesc.setTagOrder(byte[]) may expose 
internal representation by storing an externally mutable object into 
JoinDesc.tagOrder  At JoinDesc.java:by storing an externally mutable object 
into JoinDesc.tagOrder  At JoinDesc.java:[line 429] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18283/dev-support/hive-personality.sh
 |
| git revision | master / f9bd0bf |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-18283/yetus/diff-checkstyle-ql.txt
 |
| findbugs | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-18283/yetus/new-findbugs-ql.html
 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-18283/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Values of tag order cannot be null, so it can be "byte" instead of "Byte"
> -------------------------------------------------------------------------
>
>                 Key: HIVE-22083
>                 URL: https://issues.apache.org/jira/browse/HIVE-22083
>             Project: Hive
>          Issue Type: Improvement
>          Components: Hive
>            Reporter: Ivan Suller
>            Assignee: Ivan Suller
>            Priority: Minor
>         Attachments: HIVE-22083.1.patch, HIVE-22083.2.patch, 
> HIVE-22083.3.patch
>
>
> Values of tag order cannot be null, so it can be "byte" instead of "Byte". 
> Switching between Byte and byte is "cheap" - the Byte objects are cached by 
> the JVM - but it still costs a bit more memory and CPU usage.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to