[ 
https://issues.apache.org/jira/browse/HIVE-22099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906095#comment-16906095
 ] 

Karen Coppage commented on HIVE-22099:
--------------------------------------

Looks great! One comment: testJulianDates() needs a @Test annotation.

(Side note, if we really want to avoid backwards incompatibility with formats 
then 
[here|https://www.codota.com/web/assistant/code/rs/5c6692451095a50001d0175a#L90]
 is a way to avoid it. That said, switching to the java.time.DateTimeFormatter 
is a *much* better solution in the long run.)

> GenericUDFDateFormat can't handle Julian dates properly
> -------------------------------------------------------
>
>                 Key: HIVE-22099
>                 URL: https://issues.apache.org/jira/browse/HIVE-22099
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Adam Szita
>            Assignee: Adam Szita
>            Priority: Major
>              Labels: backward-incompatible
>         Attachments: HIVE-22099.0.patch
>
>
> Currently dates that belong to Julian calendar (before Oct 15, 1582) are 
> handled improperly by DateFormat UDF:
> Although the dates are in Julian calendar, the formatter insists to print 
> these according to Gregorian calendar causing multiple days of difference in 
> some cases:
>  
> {code:java}
> beeline> select date_format('1001-01-05','dd---MM--yyyy');
> +----------------+
> | _c0 |
> +----------------+
> | 30---12--1000 |
> +----------------+{code}
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to