[ 
https://issues.apache.org/jira/browse/HIVE-21604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926400#comment-16926400
 ] 

Hive QA commented on HIVE-21604:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12979931/HIVE-21604.01.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 16751 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/18518/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18518/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18518/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12979931 - PreCommit-HIVE-Build

> preCommit job should not be triggered on non-patch attachments
> --------------------------------------------------------------
>
>                 Key: HIVE-21604
>                 URL: https://issues.apache.org/jira/browse/HIVE-21604
>             Project: Hive
>          Issue Type: Bug
>          Components: Testing Infrastructure
>            Reporter: Laszlo Bodor
>            Assignee: Laszlo Bodor
>            Priority: Major
>             Fix For: 4.0.0
>
>         Attachments: HIVE-21604.01.patch, HIVE-21604.01.patch, files.txt
>
>
> latest example: HIVE-21604
> https://issues.apache.org/jira/browse/HIVE-14669?focusedCommentId=16815520&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16815520
> I think one should be able to upload any kind of attachments (e.g. 
> screenshot) without triggering the precommit job
> 2 possible ways:
> 1. strict: enable only .patch (should work)
> (2. lenient: introduce blacklist, .png ...)



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to