[ https://issues.apache.org/jira/browse/HIVE-22192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927581#comment-16927581 ]
Hive QA commented on HIVE-22192: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12980046/HIVE-22192.01.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18538/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18538/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18538/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2019-09-11 13:48:54.183 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-18538/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2019-09-11 13:48:54.186 + cd apache-github-source-source + git fetch origin >From https://github.com/apache/hive f245cb5..989d100 branch-2.3 -> origin/branch-2.3 + git reset --hard HEAD HEAD is now at 5b1afb7 HIVE-22179 Break up DDLSemanticAnalyzer - extract Function related analyzers (Miklos Gergely reviewd by Jesus Camacho Rodriguez) + git clean -f -d Removing standalone-metastore/metastore-server/src/gen/ + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at 5b1afb7 HIVE-22179 Break up DDLSemanticAnalyzer - extract Function related analyzers (Miklos Gergely reviewd by Jesus Camacho Rodriguez) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2019-09-11 13:48:55.365 + rm -rf ../yetus_PreCommit-HIVE-Build-18538 + mkdir ../yetus_PreCommit-HIVE-Build-18538 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-18538 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-18538/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: patch failed: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:346 Falling back to three-way merge... Applied patch to 'standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java' cleanly. error: patch failed: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:3460 Falling back to three-way merge... Applied patch to 'standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java' with conflicts. Going to apply patch with: git apply -p0 /data/hiveptest/working/scratch/build.patch:180: trailing whitespace. error: patch failed: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:346 Falling back to three-way merge... Applied patch to 'standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java' cleanly. error: patch failed: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:3460 Falling back to three-way merge... Applied patch to 'standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java' with conflicts. U standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java warning: 1 line adds whitespace errors. + result=1 + '[' 1 -ne 0 ']' + rm -rf yetus_PreCommit-HIVE-Build-18538 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12980046 - PreCommit-HIVE-Build > Remove ObjectPair classes > ------------------------- > > Key: HIVE-22192 > URL: https://issues.apache.org/jira/browse/HIVE-22192 > Project: Hive > Issue Type: Improvement > Components: Hive > Reporter: Miklos Gergely > Assignee: Miklos Gergely > Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22192.01.patch > > > There are two ObjectPair classes in Hive, which are identical. Actually none > of them is needed, as there is a perfectly fine Pair class with the same > functionalities in the apache common lang jar. So those superfluous classes > should be removed. > Both ObjectPair classes are for internal use only, no other project is > referencing them. -- This message was sent by Atlassian Jira (v8.3.2#803003)