[ 
https://issues.apache.org/jira/browse/HIVE-21449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929115#comment-16929115
 ] 

Hive QA commented on HIVE-21449:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
36s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
40s{color} | {color:blue} ql in master has 2225 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
54s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
34s{color} | {color:red} ql: The patch generated 1 new + 11 unchanged - 0 fixed 
= 12 total (was 11) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  3m 
41s{color} | {color:red} ql generated 27 new + 2198 unchanged - 27 fixed = 2225 
total (was 2225) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
54s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
13s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 23m  7s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Dead store to KW_IN246 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceSimilarExpressionAtom(CommonTree)
  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceSimilarExpressionAtom(CommonTree)
  At HiveParser_IdentifiersParser.java:[line 9715] |
|  |  Dead store to LPAREN236 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.subQueryExpression()
  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.subQueryExpression()
  At HiveParser_IdentifiersParser.java:[line 9217] |
|  |  Dead store to RPAREN238 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.subQueryExpression()
  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.subQueryExpression()
  At HiveParser_IdentifiersParser.java:[line 9224] |
|  |  Redundant nullcheck of sql11ReservedKeywordsUsedAsFunctionName80, which 
is known to be non-null in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.functionName()  
Redundant null check at HiveParser_IdentifiersParser.java:is known to be 
non-null in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.functionName()  
Redundant null check at HiveParser_IdentifiersParser.java:[line 3962] |
|  |  Redundant nullcheck of nonReserved316, which is known to be non-null in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.identifier()  
Redundant null check at HiveParser_IdentifiersParser.java:is known to be 
non-null in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.identifier()  
Redundant null check at HiveParser_IdentifiersParser.java:[line 12464] |
|  |  Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA22 
be a _static_ inner class?  At HiveParser_IdentifiersParser.java:inner class?  
At HiveParser_IdentifiersParser.java:[lines 32342-32355] |
|  |  Dead store to LA32_100 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 33674] |
|  |  Dead store to LA32_101 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 33687] |
|  |  Dead store to LA32_102 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 33700] |
|  |  Dead store to LA32_15 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 33570] |
|  |  Dead store to LA32_16 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 33583] |
|  |  Dead store to LA32_17 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 33596] |
|  |  Dead store to LA32_18 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 33609] |
|  |  Dead store to LA32_19 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 33622] |
|  |  Dead store to LA32_97 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 33635] |
|  |  Dead store to LA32_98 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 33648] |
|  |  Dead store to LA32_99 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 33661] |
|  |  Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA33 
be a _static_ inner class?  At HiveParser_IdentifiersParser.java:inner class?  
At HiveParser_IdentifiersParser.java:[lines 33846-33859] |
|  |  Dead store to LA37_169 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA37.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA37.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 34146] |
|  |  Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA39 
be a _static_ inner class?  At HiveParser_IdentifiersParser.java:inner class?  
At HiveParser_IdentifiersParser.java:[lines 35356-35369] |
|  |  Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA48 
be a _static_ inner class?  At HiveParser_IdentifiersParser.java:inner class?  
At HiveParser_IdentifiersParser.java:[lines 36277-36290] |
|  |  Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA52 
be a _static_ inner class?  At HiveParser_IdentifiersParser.java:inner class?  
At HiveParser_IdentifiersParser.java:[lines 36766-36779] |
|  |  Dead store to LA55_48 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA55.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA55.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 37024] |
|  |  Dead store to LA55_56 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA55.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA55.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 37037] |
|  |  Dead store to LA55_57 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA55.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA55.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 37050] |
|  |  Dead store to LA55_58 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA55.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA55.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 37063] |
|  |  Dead store to LA55_59 in 
org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA55.specialStateTransition(int,
 IntStream)  At 
HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA55.specialStateTransition(int,
 IntStream)  At HiveParser_IdentifiersParser.java:[line 37076] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18581/dev-support/hive-personality.sh
 |
| git revision | master / 38190f3 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-18581/yetus/diff-checkstyle-ql.txt
 |
| findbugs | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-18581/yetus/new-findbugs-ql.html
 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-18581/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> implement 'WITHIN GROUP' clause
> -------------------------------
>
>                 Key: HIVE-21449
>                 URL: https://issues.apache.org/jira/browse/HIVE-21449
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Laszlo Bodor
>            Assignee: Krisztian Kasa
>            Priority: Major
>         Attachments: HIVE-21449.1.patch, HIVE-21449.2.patch, 
> HIVE-21449.3.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to