[ 
https://issues.apache.org/jira/browse/HIVE-22203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929704#comment-16929704
 ] 

Hive QA commented on HIVE-22203:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12980307/HIVE-22203.01.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 16723 tests 
executed
*Failed tests:*
{noformat}
TestMiniLlapLocalCliDriver - did not produce a TEST-*.xml file (likely timed 
out) (batchId=178)
        
[union_top_level.q,vector_create_struct_table.q,llap_uncompressed.q,materialized_view_partitioned_2.q,murmur_hash_migration.q,mapjoin46.q,materialized_view_rewrite_1.q,materialized_view_create_rewrite_time_window_2.q,subquery_in_having.q,vectorized_string_funcs.q,drop_partition_with_stats.q,vectorization_1.q,fold_varchar.q,auto_join_filters.q,join0.q,mergejoin.q,vector_if_expr_2.q,orc_split_elimination.q,vector_outer_join0.q,vector_udf1.q,schema_evol_text_vec_part_all_primitive.q,vector_complex_all.q,ctas_empty_source.q,union3.q,windowing_windowspec2.q,auto_smb_mapjoin_14.q,vector_mapjoin_complex_values.q,results_cache_truncate.q,vector_join_filters.q,reduce_deduplicate_extended.q]
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[dbtxnmgr_showlocks] 
(batchId=87)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/18596/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18596/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18596/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12980307 - PreCommit-HIVE-Build

> Break up DDLSemanticAnalyzer - extract Process related analyzers
> ----------------------------------------------------------------
>
>                 Key: HIVE-22203
>                 URL: https://issues.apache.org/jira/browse/HIVE-22203
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>              Labels: pull-request-available, refactor-ddl
>         Attachments: HIVE-22203.01.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is 
> to refactor it in order to have everything cut into more handleable classes 
> under the packageĀ  org.apache.hadoop.hive.ql.exec.ddl:
>  * have a separate class for each analyzers
>  * have a package for each operation, containing an analyzer, a description, 
> and an operation, so the amount of classes under a package is more manageable
> Step #4: extract all the process related analyzers from DDLSemanticAnalyzer, 
> and move them under the new package.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to