[
https://issues.apache.org/jira/browse/HIVE-22202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16932254#comment-16932254
]
Hankó Gergely commented on HIVE-22202:
--------------------------------------
[~abstractdog]: type is always null at this point so actually pm.retrieve(null)
was called. I've checked the implementations and the only thing that
pm.retrieve(null) does is that it asserts that the persistence manager is open.
But that's still done later when the query is executed.
> Remove unnecessary code from ObjectStore.java
> ---------------------------------------------
>
> Key: HIVE-22202
> URL: https://issues.apache.org/jira/browse/HIVE-22202
> Project: Hive
> Issue Type: Task
> Components: Hive
> Reporter: Hankó Gergely
> Assignee: Hankó Gergely
> Priority: Minor
> Attachments: HIVE-22202.1.patch, HIVE-22202.2.patch,
> HIVE-22202.3.patch
>
>
> Remove unnecessary code
> * remove unnecessary/unused variables
> * remove unused private methods
> * remove unnecessary throws declarations
> * remove unnecessary conditionals that are guaranteed to always give the
> same result
> * simplify collection handling
> ** use member sort() instead of Collections.sort()
> ** use addAll() instead of adding one-by-one in a loop
> * remove Javadoc that doesn't give additional information
> * use try with resource where possible
> * remove unnecessary explicit type arguments
> * remove redundant warning suppression
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
