[
https://issues.apache.org/jira/browse/HIVE-11618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710080#comment-14710080
]
Sergio Peña commented on HIVE-11618:
------------------------------------
Thanks [~owen.omalley] for the patch.
+1
The patch looks good. I understand how you want to keep this code simple by
returning one type for a group of same primitive values. Just one small
feedback. What about adding some comments to {{CovertAstToSearchArg.getType}}
and {{PredicateLeaf.Type}} for future reference about simplicity? Other
developers might see this lack of data types, and they will be eager to add
those.
> Correct the SARG api to reunify the PredicateLeaf.Type INTEGER and LONG
> -----------------------------------------------------------------------
>
> Key: HIVE-11618
> URL: https://issues.apache.org/jira/browse/HIVE-11618
> Project: Hive
> Issue Type: Bug
> Components: Types
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-11618.patch
>
>
> The Parquet binding leaked implementation details into the generic SARG api.
> Rather than make all users of the SARG api deal with each of the specific
> types, reunify the INTEGER and LONG types.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
