[
https://issues.apache.org/jira/browse/HIVE-21884?focusedWorklogId=324727&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-324727
]
ASF GitHub Bot logged work on HIVE-21884:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Oct/19 23:46
Start Date: 07/Oct/19 23:46
Worklog Time Spent: 10m
Work Description: jcamachor commented on pull request #794: HIVE-21884
URL: https://github.com/apache/hive/pull/794#discussion_r332279696
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -4215,17 +4222,27 @@ public Table alterTable(String catName, String dbname,
String name, Table newTab
*/
public static String verifyStatsChangeCtx(String fullTableName, Map<String,
String> oldP, Map<String, String> newP,
long writeId, String
validWriteIds, boolean isColStatsChange) {
- if (validWriteIds != null && writeId > 0) return null; // We have txn
context.
+ if (validWriteIds != null && writeId > 0)
+ {
+ return null; // We have txn context.
+ }
String oldVal = oldP == null ? null :
oldP.get(StatsSetupConst.COLUMN_STATS_ACCURATE);
String newVal = newP == null ? null :
newP.get(StatsSetupConst.COLUMN_STATS_ACCURATE);
// We don't need txn context is that stats state is not being changed.
- if (StringUtils.isEmpty(oldVal) && StringUtils.isEmpty(newVal)) return
null;
+ if (StringUtils.isEmpty(oldVal) && StringUtils.isEmpty(newVal)) {
+ return null;
+ }
if (StringUtils.equalsIgnoreCase(oldVal, newVal)) {
- if (!isColStatsChange) return null; // No change in col stats or
parameters => assume no change.
+ if (!isColStatsChange)
+ {
Review comment:
Knitpick. Move to line above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 324727)
> Scheduled query support
> -----------------------
>
> Key: HIVE-21884
> URL: https://issues.apache.org/jira/browse/HIVE-21884
> Project: Hive
> Issue Type: Improvement
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21844.04.patch, HIVE-21844.05.patch,
> HIVE-21844.06.patch, HIVE-21844.07.patch, HIVE-21844.08.patch,
> HIVE-21844.09.patch, HIVE-21844.15.patch, HIVE-21844.19.patch,
> HIVE-21884.01.patch, HIVE-21884.02.patch, HIVE-21884.03.patch,
> HIVE-21884.09.patch, HIVE-21884.10.patch, HIVE-21884.10.patch,
> HIVE-21884.11.patch, HIVE-21884.12.patch, HIVE-21884.13.patch,
> HIVE-21884.14.patch, HIVE-21884.14.patch, HIVE-21884.14.patch,
> HIVE-21884.16.patch, HIVE-21884.17.patch, HIVE-21884.18.patch,
> HIVE-21884.20.patch, Scheduled queries2.pdf
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> design document:
> https://docs.google.com/document/d/1mJSFdJi_1cbxJTXC9QvGw2rQ3zzJkNfxOO6b5esmyCE/edit#
> in case the google doc is not reachable: [^Scheduled queries2.pdf]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
