[ 
https://issues.apache.org/jira/browse/HIVE-21114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954155#comment-16954155
 ] 

Hive QA commented on HIVE-21114:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983277/HIVE-21114.6.patch

{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17526 tests 
executed
*Failed tests:*
{noformat}
TestMiniLlapLocalCliDriver - did not produce a TEST-*.xml file (likely timed 
out) (batchId=186)
        
[vector_case_when_1.q,schema_evol_text_vec_part_llap_io.q,join_is_not_distinct_from.q,tez_nway_join.q,tez_schema_evolution.q,bucket_map_join_tez1.q,vector_multi_insert.q,insert_update_delete.q,schema_evol_orc_nonvec_part_all_primitive_llap_io.q,temp_table.q,external_jdbc_table_partition.q,cte_1.q,partition_pruning.q,vectorization_17.q,reopt_semijoin.q,bucket_groupby.q,vector_outer_join4.q,materialized_view_partitioned.q,orc_merge7.q,materialized_view_rewrite_3.q,bucketpruning1.q,schema_evol_orc_acidvec_table.q,vector_outer_join5.q,schema_evol_orc_acidvec_part_update_llap_io.q,external_jdbc_table3.q,vector_udf_inline.q,results_cache_temptable.q,groupby_rollup_empty2.q,auto_sortmerge_join_11.q,orc_merge_incompat_writer_version.q]
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19042/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19042/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19042/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12983277 - PreCommit-HIVE-Build

> Create read-only transactions
> -----------------------------
>
>                 Key: HIVE-21114
>                 URL: https://issues.apache.org/jira/browse/HIVE-21114
>             Project: Hive
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 4.0.0
>            Reporter: Eugene Koifman
>            Assignee: Denys Kuzmenko
>            Priority: Major
>         Attachments: HIVE-21114.1.patch, HIVE-21114.2.patch, 
> HIVE-21114.3.patch, HIVE-21114.4.patch, HIVE-21114.5.patch, HIVE-21114.6.patch
>
>
> With HIVE-21036 we have a way to indicate that a txn is read only.
> We should (at least in auto-commit mode) determine if the single stmt is a 
> read and mark the txn accordingly.  
> Then we can optimize {{TxnHandler.commitTxn()}} so that it doesn't do any 
> checks in write_set etc.
> {{TxnHandler.commitTxn()}} already starts with {{lockTransactionRecord(stmt, 
> txnid, TXN_OPEN)}} so it can read the txn type in the same SQL stmt.
> HiveOperation only has QUERY, which includes Insert and Select, so this 
> requires figuring out how to determine if a query is a SELECT.  By the time 
> {{Driver.openTransaction();}} is called, we have already parsed the query so 
> there should be a way to know if the statement only reads.
> For multi-stmt txns (once these are supported) we should allow user to 
> indicate that a txn is read-only and then not allow any statements that can 
> make modifications in this txn.  This should be a different jira.
> cc [~ikryvenko]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to