[ 
https://issues.apache.org/jira/browse/HIVE-22329?focusedWorklogId=330911&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330911
 ]

ASF GitHub Bot logged work on HIVE-22329:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Oct/19 09:14
            Start Date: 19/Oct/19 09:14
    Worklog Time Spent: 10m 
      Work Description: miklosgergely commented on issue #810: HIVE-22329 
Create DriverContext
URL: https://github.com/apache/hive/pull/810#issuecomment-544118636
 
 
   @kgyrtkirk I've modified the patch according to your comments. Also modified 
the logic of passing the arguments to a test, now the TaskQueue and the context 
are passed at the initialize call, and execute has no argument, which is much 
cleaner. TaskQueue now doesn't exposes the context.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 330911)
    Time Spent: 1h 10m  (was: 1h)

> Create DriverContext
> --------------------
>
>                 Key: HIVE-22329
>                 URL: https://issues.apache.org/jira/browse/HIVE-22329
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>         Attachments: HIVE-22329.01.patch, HIVE-22329.02.patch, 
> HIVE-22329.03.patch, HIVE-22329.04.patch
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> The current DriverContext class is not really a context, rather a queue, thus 
> it should be renamed to DriverQueue. At the same time Driver has a a lot of 
> fields, they should be in a real context class called DriverContext, which 
> would also facilitate the extraction of independent parts of the Driver class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to