[ https://issues.apache.org/jira/browse/HIVE-22414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962505#comment-16962505 ]
Hive QA commented on HIVE-22414: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12984242/HIVE-22414.1.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19198/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19198/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19198/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Tests exited with: Exception: Patch URL https://issues.apache.org/jira/secure/attachment/12984242/HIVE-22414.1.patch was found in seen patch url's cache and a test was probably run already on it. Aborting... {noformat} This message is automatically generated. ATTACHMENT ID: 12984242 - PreCommit-HIVE-Build > Make LLAP CacheTags more memory efficient > ----------------------------------------- > > Key: HIVE-22414 > URL: https://issues.apache.org/jira/browse/HIVE-22414 > Project: Hive > Issue Type: Improvement > Components: llap > Reporter: Ádám Szita > Assignee: Ádám Szita > Priority: Major > Attachments: HIVE-22414.0.patch, HIVE-22414.1.patch > > > MultiPartitionCacheTag relies on LinkedLists. > A LinkedList object that holds e.g. 2 nodes consumes 112 bytes roughly in > this composition: > * 16 bytes for LinkedList object header > * 8 bytes for referring head > * 8 bytes for referring tail > * 80 = 2 x (16 bytes for LinkedList$Node header, 3 x 8 bytes for referring > prev, next, item) > This is a lot, so I propose to replace LinkedList in MultiPartitionCacheTag > with a simple String array. (For a similar scenario an array would take 16 + > 8 + 2 x 8 = 40 bytes, as per header, count, and 2 references for our actual > objects). -- This message was sent by Atlassian Jira (v8.3.4#803005)