[
https://issues.apache.org/jira/browse/HIVE-22523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980380#comment-16980380
]
Slim Bouguerra commented on HIVE-22523:
---------------------------------------
[~amagyar] then please leave the {code} enqueueInternal {code} call as is since
it is by design not blocking and it is not good idea to remove it if there is
not reason.
As i said i do not think this is the issue why we get the OOM.
> The error handler in LlapRecordReader might block if its queue is full
> ----------------------------------------------------------------------
>
> Key: HIVE-22523
> URL: https://issues.apache.org/jira/browse/HIVE-22523
> Project: Hive
> Issue Type: Bug
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22523.1.patch
>
>
> In setError() we set the value of an atomic reference (pendingError) and we
> also put the error in a queue. The latter seems not just unnecessary but it
> might block the caller of the handler if the queue is full. Also closing of
> the reader is might not properly handled as some of the flags are not
> volatile.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
