[
https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=349593&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-349593
]
ASF GitHub Bot logged work on HIVE-22463:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Nov/19 06:15
Start Date: 26/Nov/19 06:15
Worklog Time Spent: 10m
Work Description: t3rmin4t0r commented on pull request #856: HIVE-22463
decimal64 multiplication
URL: https://github.com/apache/hive/pull/856#discussion_r350558668
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
##########
@@ -3398,7 +3408,8 @@ private VectorExpression
tryDecimal64Between(VectorExpressionDescriptor.Mode mod
cl, childrenAfterNot, VectorExpressionDescriptor.Mode.PROJECTION,
/* isDecimal64ScaleEstablished */ true,
/* decimal64ColumnScale */ ((DecimalTypeInfo)
colExpr.getTypeInfo()).getScale(),
- returnTypeInfo, DataTypePhysicalVariation.NONE);
+ returnTypeInfo, DataTypePhysicalVariation.NONE,
+ /* dontRescaleArguments */ false);
Review comment:
with the comment that does look very odd - "don't = false"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 349593)
Time Spent: 2h 20m (was: 2h 10m)
> Support Decimal64 column multiplication with decimal64 Column/Scalar
> --------------------------------------------------------------------
>
> Key: HIVE-22463
> URL: https://issues.apache.org/jira/browse/HIVE-22463
> Project: Hive
> Issue Type: Bug
> Reporter: Ramesh Kumar Thangarajan
> Assignee: Ramesh Kumar Thangarajan
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch,
> HIVE-22463.11.patch, HIVE-22463.2.patch, HIVE-22463.3.patch,
> HIVE-22463.5.patch, HIVE-22463.6.patch, HIVE-22463.7.patch,
> HIVE-22463.8.patch, HIVE-22463.9.patch
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Support Decimal64 column multiplication with decimal64 Column/Scalar
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
