[ https://issues.apache.org/jira/browse/HIVE-22569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987838#comment-16987838 ]
Vineet Garg commented on HIVE-22569: ------------------------------------ [~belugabehr] It will be nice to leave a comment in class file to explain why it is immutable. Otherwise +1 pending tests > PartitionPruner use Collections Class > ------------------------------------- > > Key: HIVE-22569 > URL: https://issues.apache.org/jira/browse/HIVE-22569 > Project: Hive > Issue Type: Improvement > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Minor > Attachments: HIVE.22569.1.patch > > > Make class {{PrunedPartitionList.java}} more immutable. It kinda is already. > Immutable classes are easier to reason about. > Use {{Collections.emptyXXX}} in {{PartitionPruner}} to save an object > instantiation at runtime. -- This message was sent by Atlassian Jira (v8.3.4#803005)