[ https://issues.apache.org/jira/browse/HIVE-22327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989613#comment-16989613 ]
Peter Vary commented on HIVE-22327: ----------------------------------- [~dkuzmenko]: 2 quick comments: * Maybe logging out the actual db queries would be a good idea, like: {code} LOG.debug("Going to execute select <" + query.replaceAll("\\?", "{}") + ">", quoteString(replPolicy)); {code} * I would prefer to have a null check in DbNotificationListener in all 3 places, like: {code} if (openTxnEvent.getTxnType() != null && openTxnEvent.getTxnType() == TxnType.READ_ONLY) { return; } {code} Otherwise looks good to me +1 > Repl: Ignore read-only transactions in notification log > ------------------------------------------------------- > > Key: HIVE-22327 > URL: https://issues.apache.org/jira/browse/HIVE-22327 > Project: Hive > Issue Type: Improvement > Components: repl > Reporter: Gopal Vijayaraghavan > Assignee: Denys Kuzmenko > Priority: Major > Attachments: HIVE-22327.1.patch, HIVE-22327.10.patch, > HIVE-22327.11.patch, HIVE-22327.12.patch, HIVE-22327.13.patch, > HIVE-22327.14.patch, HIVE-22327.15.patch, HIVE-22327.2.patch, > HIVE-22327.3.patch, HIVE-22327.4.patch, HIVE-22327.5.patch, > HIVE-22327.6.patch, HIVE-22327.7.patch, HIVE-22327.8.patch, HIVE-22327.9.patch > > > Read txns need not be replicated. -- This message was sent by Atlassian Jira (v8.3.4#803005)